Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project configuration menu contribution #556

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

Bananeweizen
Copy link
Collaborator

That's the place where all project conversion and configuration contributions of different plugins should appear.
While that's basically a duplication of the sub menus in the Checkstyle command, it's the place where Eclipse developers might look first when trying to enable/disable checkstyle for a project.
The menu items are only visible if all selected projects do/don't have the checkstyle nature and are currently open.

The other menu items in this menu depend on what you have installed, e.g. you might see Xtext, Gradle, Groovy, Maven and other items appear there.
grafik

That's the place where all project conversion and configuration
contributions of different plugins should appear.

While that's basically a duplication of the sub menus in the Checkstyle
command, it's the place where Eclipse developers might look first when
trying to enable/disable checkstyle for a project.
@romani
Copy link
Member

romani commented Sep 10, 2023

I highly recommend to keep "link" to PR or issue where more details (like image, ....) or conversation can happen and being useful to understand reasoning on code changes.
When we are lazy to create issue in main project, we create PR and change commit to reference PR number like "Pull #556: ......".

@Calixte Calixte merged commit 1f02f11 into checkstyle:master Sep 11, 2023
6 checks passed
@Bananeweizen Bananeweizen deleted the configuration_menu branch September 12, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants