Issue #433: Fix all localization issues

* enable PDE compiler check for missing localizations in all projects * unify PDE project settings for all plugin projects * fix missing tooltip * localize all remaining non-localized strings in plugin.xml * set translatable property in all own schemas where applicable * move all localization files to the default OSGi localization property location and remove the superfluous manifest headers
checkstyle · Apr 15, 2023 · 750b869 · 750b869
1 parent 306df36
commit 750b869
Show file tree

Hide file tree

Showing 41 changed files with 203 additions and 71 deletions.
diff --git a/docs/sitemap.xml b/docs/sitemap.xml
@@ -15,77 +15,77 @@
   -->
   <url>
     <loc>https://checkstyle.org/eclipse-cs/</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/releasenotes</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/install</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/project-setup</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/custom-config</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/filters</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/configtypes</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/properties</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/filesets</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/preferences</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/extensions</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/custom-checks</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/builtin-config</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/custom-filters</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
   <url>
     <loc>https://checkstyle.org/eclipse-cs/#!/faq</loc>
-    <lastmod>2023-04-08</lastmod>
+    <lastmod>2023-04-15</lastmod>
     <changefreq>weekly</changefreq>
   </url>
 </urlset>
diff --git a/net.sf.eclipsecs.branding/.settings/org.eclipse.pde.core.prefs b/net.sf.eclipsecs.branding/.settings/org.eclipse.pde.core.prefs
@@ -0,0 +1,2 @@
+eclipse.preferences.version=1
+resolve.requirebundle=false
diff --git a/net.sf.eclipsecs.branding/.settings/org.eclipse.pde.prefs b/net.sf.eclipsecs.branding/.settings/org.eclipse.pde.prefs
@@ -20,7 +20,7 @@ compilers.p.missing-version-import-package=2
 compilers.p.missing-version-require-bundle=2
 compilers.p.no-required-att=0
 compilers.p.no.automatic.module=0
-compilers.p.not-externalized-att=2
+compilers.p.not-externalized-att=0
 compilers.p.service.component.without.lazyactivation=0
 compilers.p.unknown-attribute=0
 compilers.p.unknown-class=0

diff --git a/net.sf.eclipsecs.branding/META-INF/MANIFEST.MF b/net.sf.eclipsecs.branding/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
-Bundle-Name: Eclipse Checkstyle
+Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: net.sf.eclipsecs.branding
 Bundle-Version: 10.6.0.qualifier
-Bundle-Vendor: Eclipse Checkstyle Project
+Bundle-Vendor: %Bundle-Vendor
 Automatic-Module-Name: net.sf.eclipsecs.branding
diff --git a/net.sf.eclipsecs.branding/OSGI-INF/l10n/bundle.properties b/net.sf.eclipsecs.branding/OSGI-INF/l10n/bundle.properties
@@ -0,0 +1,3 @@
+#Properties file for net.sf.eclipsecs.branding
+Bundle-Name = Eclipse Checkstyle
+Bundle-Vendor = Eclipse Checkstyle Project
diff --git a/net.sf.eclipsecs.branding/build.properties b/net.sf.eclipsecs.branding/build.properties
@@ -1,4 +1,5 @@
 bin.includes = META-INF/,\
                about.ini,\
                about.properties,\
-               checkstyle_small.png
+               checkstyle_small.png,\
+               OSGI-INF/
diff --git a/net.sf.eclipsecs.checkstyle/.settings/org.eclipse.pde.core.prefs b/net.sf.eclipsecs.checkstyle/.settings/org.eclipse.pde.core.prefs
@@ -0,0 +1,2 @@
+eclipse.preferences.version=1
+resolve.requirebundle=false
diff --git a/net.sf.eclipsecs.checkstyle/.settings/org.eclipse.pde.prefs b/net.sf.eclipsecs.checkstyle/.settings/org.eclipse.pde.prefs
@@ -20,7 +20,7 @@ compilers.p.missing-version-import-package=2
 compilers.p.missing-version-require-bundle=2
 compilers.p.no-required-att=0
 compilers.p.no.automatic.module=0
-compilers.p.not-externalized-att=2
+compilers.p.not-externalized-att=0
 compilers.p.service.component.without.lazyactivation=0
 compilers.p.unknown-attribute=0
 compilers.p.unknown-class=0

diff --git a/net.sf.eclipsecs.checkstyle/META-INF/MANIFEST.MF b/net.sf.eclipsecs.checkstyle/META-INF/MANIFEST.MF
@@ -1,9 +1,9 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
-Bundle-Name: Checkstyle Library
+Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: net.sf.eclipsecs.checkstyle
 Bundle-Version: 10.6.0.qualifier
-Bundle-Vendor: Eclipse Checkstyle Project
+Bundle-Vendor: %Bundle-Vendor
 Bundle-ActivationPolicy: lazy
 Bundle-RequiredExecutionEnvironment: JavaSE-11
 Export-Package: .,

diff --git a/net.sf.eclipsecs.checkstyle/OSGI-INF/l10n/bundle.properties b/net.sf.eclipsecs.checkstyle/OSGI-INF/l10n/bundle.properties
@@ -0,0 +1,3 @@
+#Properties file for net.sf.eclipsecs.checkstyle
+Bundle-Name = Checkstyle Library
+Bundle-Vendor = Eclipse Checkstyle Project
diff --git a/net.sf.eclipsecs.checkstyle/build.properties b/net.sf.eclipsecs.checkstyle/build.properties
@@ -1,7 +1,8 @@
 bin.includes = META-INF/,\
                .,\
                license/,\
-               checkstyle-10.6.0-all.jar
+               checkstyle-10.6.0-all.jar,\
+               OSGI-INF/
 jars.compile.order = .
 source.. = metadata/
 javacDefaultEncoding.. = UTF-8
diff --git a/net.sf.eclipsecs.checkstyle/plugin.properties b/net.sf.eclipsecs.checkstyle/plugin.properties
diff --git a/net.sf.eclipsecs.core/.settings/org.eclipse.pde.core.prefs b/net.sf.eclipsecs.core/.settings/org.eclipse.pde.core.prefs
@@ -1,3 +1,2 @@
-#Tue Oct 04 19:15:04 CEST 2011
 eclipse.preferences.version=1
 resolve.requirebundle=false
diff --git a/net.sf.eclipsecs.core/.settings/org.eclipse.pde.prefs b/net.sf.eclipsecs.core/.settings/org.eclipse.pde.prefs
@@ -20,7 +20,7 @@ compilers.p.missing-version-import-package=2
 compilers.p.missing-version-require-bundle=2
 compilers.p.no-required-att=0
 compilers.p.no.automatic.module=0
-compilers.p.not-externalized-att=2
+compilers.p.not-externalized-att=0
 compilers.p.service.component.without.lazyactivation=0
 compilers.p.unknown-attribute=0
 compilers.p.unknown-class=0

diff --git a/net.sf.eclipsecs.core/META-INF/MANIFEST.MF b/net.sf.eclipsecs.core/META-INF/MANIFEST.MF
@@ -1,5 +1,5 @@
 Manifest-Version: 1.0
-Bundle-Name: Eclipse Checkstyle
+Bundle-Name: %Bundle-Name
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: net.sf.eclipsecs.core;singleton:=true
 Bundle-Version: 10.6.0.qualifier
@@ -8,10 +8,9 @@ Bundle-ClassPath: .,
  lib/checkstyle-10.6.0-all.jar
 Bundle-Activator: net.sf.eclipsecs.core.CheckstylePlugin
 Bundle-ActivationPolicy: lazy
-Bundle-Vendor: Eclipse Checkstyle Project
+Bundle-Vendor: %Bundle-Vendor
 Require-Bundle: net.sf.eclipsecs.checkstyle;visibility:=reexport
 Eclipse-BuddyPolicy: registered
-Bundle-Localization: core
 Export-Package: net.sf.eclipsecs.core,
  net.sf.eclipsecs.core.builder,
  net.sf.eclipsecs.core.config,

diff --git a/net.sf.eclipsecs.core/core.properties → ...secs.core/OSGI-INF/l10n/bundle.properties b/net.sf.eclipsecs.core/core.properties → ...secs.core/OSGI-INF/l10n/bundle.properties
@@ -37,3 +37,11 @@ DerivedFilesFilter.label         = derived (generated) files
 
 FilesOlderThanOneDayFilter.description  = Exclude all files that are older than one day.
 FilesOlderThanOneDayFilter.label        = files older than one day
+
+Bundle-Name = Eclipse Checkstyle
+Bundle-Vendor = Eclipse Checkstyle Project
+extension-point.addon-provider.name = Checkstyle Addon provider
+extension-point.configuration-types.name = Checkstyle configuration types
+extension-point.configurations.name = Checkstyle configurations
+extension-point.filters.name = Checkstyle filters
+extension-point.save-filters.name = Checkstyle configuration save filters
diff --git a/net.sf.eclipsecs.core/build.properties b/net.sf.eclipsecs.core/build.properties
@@ -6,8 +6,6 @@ bin.includes = .,\
                license/,\
                plugin.xml,\
                schema/,\
-               core.properties,\
-               lib/checkstyle-10.6.0-all.jar
-
+               lib/checkstyle-10.6.0-all.jar,\
+               OSGI-INF/
 javacDefaultEncoding.. = UTF-8
-
diff --git a/net.sf.eclipsecs.core/plugin.xml b/net.sf.eclipsecs.core/plugin.xml
@@ -3,20 +3,20 @@
 <plugin>
 
     <!-- defines the extension point to contribute Checkstyle addons. -->
-    <extension-point id="checkstyleAddonProvider" name="Checkstyle Addon provider"
+    <extension-point id="checkstyleAddonProvider" name="%extension-point.addon-provider.name"
         schema="schema/checkstyleAddonProvider.exsd"/>
 
     <!-- defines the extension point to contribute custom configuration type. -->
-    <extension-point id="configurationtypes" name="Checkstyle configuration types" schema="schema/configtypes.exsd"/>
+    <extension-point id="configurationtypes" name="%extension-point.configuration-types.name" schema="schema/configtypes.exsd"/>
 
     <!-- defines the extension point to contribute default checkstyle configurations to the checkstyle plugin -->
-    <extension-point id="configurations" name="Checkstyle configurations" schema="schema/configurations.exsd"/>
+    <extension-point id="configurations" name="%extension-point.configurations.name" schema="schema/configurations.exsd"/>
 
     <!-- defines the extension point to contribute custom filters to the checkstyle plugin -->
-    <extension-point id="filters" name="Checkstyle filters" schema="schema/filters.exsd"/>
+    <extension-point id="filters" name="%extension-point.filters.name" schema="schema/filters.exsd"/>
 
     <!-- defines the extension point to contribute custom configuration save filters -->
-    <extension-point id="saveFilters" name="Checkstyle configuration save filters" schema="schema/saveFilters.exsd"/>
+    <extension-point id="saveFilters" name="%extension-point.save-filters.name" schema="schema/saveFilters.exsd"/>
 
     <extension id="CheckstyleBuilder" name="%CheckstyleBuilder.name" point="org.eclipse.core.resources.builders">
         <builder>

diff --git a/net.sf.eclipsecs.core/schema/configtypes.exsd b/net.sf.eclipsecs.core/schema/configtypes.exsd
@@ -40,6 +40,9 @@ The id is used to identify the specific filter set.
                <documentation>
                   The human readable name of this extension.
                </documentation>
+               <appinfo>
+                  <meta.attribute translatable="true"/>
+               </appinfo>
             </annotation>
          </attribute>
       </complexType>

diff --git a/net.sf.eclipsecs.core/schema/configurations.exsd b/net.sf.eclipsecs.core/schema/configurations.exsd
@@ -40,6 +40,9 @@ The id is used to identify the specific filter set.
                <documentation>
                   The human readable name of this extension.
                </documentation>
+               <appinfo>
+                  <meta.attribute translatable="true"/>
+               </appinfo>
             </annotation>
          </attribute>
       </complexType>

diff --git a/net.sf.eclipsecs.core/schema/filters.exsd b/net.sf.eclipsecs.core/schema/filters.exsd
@@ -40,6 +40,9 @@ The id is used to identify the specific filter set.
                <documentation>
                   The human readable name of this extension.
                </documentation>
+               <appinfo>
+                  <meta.attribute translatable="true"/>
+               </appinfo>
             </annotation>
          </attribute>
       </complexType>
@@ -75,6 +78,9 @@ The filter class must implement &lt;code&gt;net.sf.eclipsecs.core.filters.IFilte
                <documentation>
                   The human readable name of this filter.
                </documentation>
+               <appinfo>
+                  <meta.attribute translatable="true"/>
+               </appinfo>
             </annotation>
          </attribute>
          <attribute name="selected" type="string" use="default" value="false">

diff --git a/net.sf.eclipsecs.core/schema/saveFilters.exsd b/net.sf.eclipsecs.core/schema/saveFilters.exsd
@@ -40,6 +40,9 @@ A save filter can modify the order of modules, add modules required in a certain
                <documentation>
                   The human readable name of this extension.
                </documentation>
+               <appinfo>
+                  <meta.attribute translatable="true"/>
+               </appinfo>
             </annotation>
          </attribute>
       </complexType>

diff --git a/net.sf.eclipsecs.doc/.settings/org.eclipse.pde.core.prefs b/net.sf.eclipsecs.doc/.settings/org.eclipse.pde.core.prefs
@@ -0,0 +1,2 @@
+eclipse.preferences.version=1
+resolve.requirebundle=false
diff --git a/net.sf.eclipsecs.doc/.settings/org.eclipse.pde.prefs b/net.sf.eclipsecs.doc/.settings/org.eclipse.pde.prefs
@@ -0,0 +1,35 @@
+compilers.f.unresolved-features=1
+compilers.f.unresolved-plugins=1
+compilers.incompatible-environment=0
+compilers.p.build=0
+compilers.p.build.bin.includes=0
+compilers.p.build.encodings=0
+compilers.p.build.java.compiler=2
+compilers.p.build.java.compliance=0
+compilers.p.build.missing.output=2
+compilers.p.build.output.library=0
+compilers.p.build.source.library=0
+compilers.p.build.src.includes=0
+compilers.p.deprecated=2
+compilers.p.discouraged-class=0
+compilers.p.exec-env-too-low=1
+compilers.p.internal=0
+compilers.p.missing-packages=2
+compilers.p.missing-version-export-package=2
+compilers.p.missing-version-import-package=2
+compilers.p.missing-version-require-bundle=2
+compilers.p.no-required-att=0
+compilers.p.no.automatic.module=0
+compilers.p.not-externalized-att=0
+compilers.p.service.component.without.lazyactivation=0
+compilers.p.unknown-attribute=0
+compilers.p.unknown-class=0
+compilers.p.unknown-element=0
+compilers.p.unknown-identifier=0
+compilers.p.unknown-resource=0
+compilers.p.unresolved-ex-points=0
+compilers.p.unresolved-import=0
+compilers.s.create-docs=false
+compilers.s.doc-folder=doc
+compilers.s.open-tags=1
+eclipse.preferences.version=1
diff --git a/net.sf.eclipsecs.doc/META-INF/MANIFEST.MF b/net.sf.eclipsecs.doc/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
-Bundle-Name: Eclipse Checkstyle Documentation
+Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: net.sf.eclipsecs.doc;singleton:=true
 Bundle-Version: 10.6.0.qualifier
-Bundle-Vendor: Eclipse Checkstyle Project
+Bundle-Vendor: %Bundle-Vendor
 Automatic-Module-Name: net.sf.eclipsecs.doc
diff --git a/net.sf.eclipsecs.doc/OSGI-INF/l10n/bundle.properties b/net.sf.eclipsecs.doc/OSGI-INF/l10n/bundle.properties
@@ -0,0 +1,3 @@
+#Properties file for net.sf.eclipsecs.doc
+Bundle-Name = Eclipse Checkstyle Documentation
+Bundle-Vendor = Eclipse Checkstyle Project
diff --git a/net.sf.eclipsecs.doc/build.properties b/net.sf.eclipsecs.doc/build.properties
@@ -1,5 +1,6 @@
 bin.includes = META-INF/,\
                docs/,\
                toc.xml,\
-               plugin.xml
+               plugin.xml,\
+               OSGI-INF/
 generateSourceBundle=false               
diff --git a/net.sf.eclipsecs.sample/.settings/org.eclipse.pde.core.prefs b/net.sf.eclipsecs.sample/.settings/org.eclipse.pde.core.prefs
@@ -0,0 +1,2 @@
+eclipse.preferences.version=1
+resolve.requirebundle=false
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		eclipse.preferences.version=1
		resolve.requirebundle=false