Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #866: Convert project-to-test into yaml #867

Closed

Conversation

relentless-pursuit
Copy link
Collaborator

Resolves #866

@relentless-pursuit relentless-pursuit force-pushed the convertYAML branch 2 times, most recently from d0265da to c1f6557 Compare May 27, 2024 10:28
@rnveach
Copy link
Member

rnveach commented May 27, 2024

There is a file conflict.

Also, if we are making this a YAML file, I would expect the extension to be .yml.

I also think this type of change will be pretty wide. Our regression groovy will need to be modified to now work with this new file format.

This also will impact our shell scripts, some of which are still one of a kind like the antlr regression (launch_diff_antlr.sh) which has no groovy equivalent.

I am not sure if we need to update our GH action in main repo that allows users to use custom test property file.

If we rename the file, the groovy change will have to be done in this same PR. You may want to consider just creating a whole new file, and then do the groovy update and property deletion in another PR.

@rnveach
Copy link
Member

rnveach commented May 27, 2024

Final note from me, I dislike commenting out system, if that even works for YAMLs.

Can we switch to something like enabled/disabled instead?

This will also impact our project specific regression in main repo. We comment out individual lines that match project name. This will make enabling/disabling specific projects a bit more complex. I think enable/disable option is the best in this case, but we will need a way to locate and enable project specifics.

@nrmancuso
Copy link
Member

nrmancuso commented May 27, 2024

Can we switch to something like enabled/disabled instead?

Second this. We have no need for commenting out if we have this field. We will need to get familiar with yq

@relentless-pursuit relentless-pursuit force-pushed the convertYAML branch 2 times, most recently from 46d6a6c to 0825237 Compare May 28, 2024 17:41
@rnveach rnveach marked this pull request as draft May 28, 2024 18:09
@romani
Copy link
Member

romani commented May 30, 2024

Please send PR to https://github.com/romani/contribution

@romani romani closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkstyle-tester: Yaml format for project list
4 participants