Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #614: resolves idea violations #736

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Issue #614: resolves idea violations #736

merged 1 commit into from
Dec 30, 2022

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Dec 29, 2022 •
edited
Loading

Issue #614

This doesn't resolve all of them but it is a start.

@rnveach
Copy link
Member Author

rnveach commented Dec 29, 2022

Violations left after this PR:

Abstraction issues
'public' method with 'boolean' parameter (Errors) (1)
Class metrics
Overly complex anonymous class (Errors) (1)
Inheritance issues
Abstract class without abstract methods (Errors) (2)
JUnit
JUnit test method without any assertions (Errors) (1)
Probable bugs
String concatenation as argument to 'format()' call (1)
Security
Insecure random number generation (Errors) (1)

@rnveach rnveach requested a review from romani December 29, 2022 17:19
@romani
Copy link
Member

romani commented Dec 29, 2022

CI is not happy.

@rnveach
Copy link
Member Author

rnveach commented Dec 29, 2022

None of the failures are from my changes.

@romani
Copy link
Member

romani commented Dec 29, 2022

I restarted all. Travis is ok, known system problem on their side.
appveyor is very strange ....

@romani romani merged commit 44e4c77 into checkstyle:master Dec 30, 2022
@rnveach rnveach deleted the issue_614 branch December 30, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees

@romani romani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnveach @romani