-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run aarch64 tests native via actuated #2431
Merged
avagin
merged 5 commits into
checkpoint-restore:criu-dev
from
adrianreber:2024-07-04-actuated
Aug 16, 2024
Merged
ci: run aarch64 tests native via actuated #2431
avagin
merged 5 commits into
checkpoint-restore:criu-dev
from
adrianreber:2024-07-04-actuated
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianreber
force-pushed
the
2024-07-04-actuated
branch
6 times, most recently
from
July 4, 2024 15:22
07e7285
to
6ecb2e9
Compare
adrianreber
force-pushed
the
2024-07-04-actuated
branch
5 times, most recently
from
July 5, 2024 08:25
0024b9d
to
39cfee6
Compare
rst0git
reviewed
Jul 5, 2024
adrianreber
force-pushed
the
2024-07-04-actuated
branch
2 times, most recently
from
July 6, 2024 08:15
6269d09
to
fcb7e60
Compare
rst0git
reviewed
Jul 7, 2024
rst0git
reviewed
Jul 7, 2024
rst0git
reviewed
Jul 7, 2024
rst0git
reviewed
Jul 7, 2024
Would you be able to check if disabling RT throttling would fix this problem?
|
rst0git
reviewed
Jul 7, 2024
rst0git
reviewed
Jul 7, 2024
adrianreber
force-pushed
the
2024-07-04-actuated
branch
from
July 8, 2024 17:05
fcb7e60
to
2a526a3
Compare
rst0git
reviewed
Jul 8, 2024
adrianreber
force-pushed
the
2024-07-04-actuated
branch
from
July 8, 2024 17:50
2a526a3
to
5ac1153
Compare
Running 'crit x ./ rss' on aarch64 crashes with: File "/home/criu/crit/crit/__main__.py", line 331, in explore_rss while vmas[vmi]['start'] < pme: ~~~~^^^^^ IndexError: list index out of range This adds an additional check to the while loop to do access indexes out of range. Signed-off-by: Adrian Reber <[email protected]>
Previously the check was just if /sys/fs/selinux is mounted. This extends the check to see if all necessary tools are installed. Signed-off-by: Adrian Reber <[email protected]>
Some test environments (Actuated runners for example) do not support maclvan devices. Skip tests depending on it automatically. Signed-off-by: Adrian Reber <[email protected]>
Currently coredump only works on x86_64. Fail early on any other architecture. Signed-off-by: Adrian Reber <[email protected]>
Signed-off-by: Adrian Reber <[email protected]>
adrianreber
force-pushed
the
2024-07-04-actuated
branch
from
July 8, 2024 17:55
5ac1153
to
c44833c
Compare
rst0git
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A friendly reminder that this PR had no activity for 30 days. |
rst0git
added
no-auto-close
Don't auto-close as a stale issue
and removed
stale-pr
labels
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings aarch64 based tests to CRIU GitHub CI setup. The difference to the previous configurations is that now actually all tests (almost) are being run.
The tests on the actuated runners are with following limitations:
change_mnt_context
test fails withsched_policy00
test fails with