Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run aarch64 tests native via actuated #2431

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

adrianreber
Copy link
Member

@adrianreber adrianreber commented Jul 4, 2024

This brings aarch64 based tests to CRIU GitHub CI setup. The difference to the previous configurations is that now actually all tests (almost) are being run.

The tests on the actuated runners are with following limitations:

  • tests using macvlan have to be skipped as that module is not available
  • the coredump python script is x86_64 only (register names and other arch specific code)
  • the change_mnt_context test fails with
       #    ./change_mnt_context --pidfile=change_mnt_context.pid --outfile=change_mnt_context.out
       #    45: ERR: change_mnt_context.c:23: mount (errno = 22 (Invalid argument))
    
  • the sched_policy00 test fails with
       #    5: ERR: sched_policy00.c:55: Can't set policy (errno = 1 (Operation not permitted))
       #    4: ERR: test.c:320: Test exited unexpectedly with code 255
    
  • in combination with '--remote-lazy-pages' following error occurs:
        #  138: FAIL: maps05.c:84: Data corrupted at page 1639 (errno = 11 (Resource temporarily unavailable))
    
  • the crit test case triggers an out of range error when displaying rss on aarch64 which was fixed based on an old commit from @rst0git

@adrianreber adrianreber closed this Jul 4, 2024
@adrianreber adrianreber reopened this Jul 4, 2024
@adrianreber adrianreber force-pushed the 2024-07-04-actuated branch 6 times, most recently from 07e7285 to 6ecb2e9 Compare July 4, 2024 15:22
@adrianreber adrianreber closed this Jul 4, 2024
@adrianreber adrianreber reopened this Jul 4, 2024
@adrianreber adrianreber force-pushed the 2024-07-04-actuated branch 5 times, most recently from 0024b9d to 39cfee6 Compare July 5, 2024 08:25
@adrianreber adrianreber closed this Jul 5, 2024
@adrianreber adrianreber reopened this Jul 5, 2024
@adrianreber adrianreber force-pushed the 2024-07-04-actuated branch 2 times, most recently from 6269d09 to fcb7e60 Compare July 6, 2024 08:15
@adrianreber adrianreber marked this pull request as ready for review July 6, 2024 12:40
scripts/ci/run-ci-tests.sh Outdated Show resolved Hide resolved
scripts/ci/run-ci-tests.sh Outdated Show resolved Hide resolved
@rst0git
Copy link
Member

rst0git commented Jul 7, 2024

the sched_policy00 test fails with

Would you be able to check if disabling RT throttling would fix this problem?

sudo sysctl -w kernel.sched_rt_runtime_us=-1

@adrianreber adrianreber force-pushed the 2024-07-04-actuated branch from fcb7e60 to 2a526a3 Compare July 8, 2024 17:05
@adrianreber adrianreber force-pushed the 2024-07-04-actuated branch from 2a526a3 to 5ac1153 Compare July 8, 2024 17:50
Running 'crit x ./ rss' on aarch64 crashes with:

    File "/home/criu/crit/crit/__main__.py", line 331, in explore_rss
      while vmas[vmi]['start'] < pme:
            ~~~~^^^^^
  IndexError: list index out of range

This adds an additional check to the while loop to do access indexes out
of range.

Signed-off-by: Adrian Reber <[email protected]>
Previously the check was just if /sys/fs/selinux is mounted. This
extends the check to see if all necessary tools are installed.

Signed-off-by: Adrian Reber <[email protected]>
Some test environments (Actuated runners for example) do not support
maclvan devices. Skip tests depending on it automatically.

Signed-off-by: Adrian Reber <[email protected]>
Currently coredump only works on x86_64. Fail early on any other
architecture.

Signed-off-by: Adrian Reber <[email protected]>
@adrianreber adrianreber force-pushed the 2024-07-04-actuated branch from 5ac1153 to c44833c Compare July 8, 2024 17:55
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Aug 9, 2024

A friendly reminder that this PR had no activity for 30 days.

@rst0git rst0git added no-auto-close Don't auto-close as a stale issue and removed stale-pr labels Aug 9, 2024
@avagin avagin merged commit 5ba1f84 into checkpoint-restore:criu-dev Aug 16, 2024
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-auto-close Don't auto-close as a stale issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants