Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PayoutsTransactionsType FastFounds to FastFunds #425

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fixed PayoutsTransactionsType FastFounds to FastFunds #425

merged 1 commit into from
Sep 30, 2024

Conversation

nicklmiller
Copy link
Contributor

@nicklmiller nicklmiller commented Sep 30, 2024 •
edited
Loading

The PayoutsTransactionsType enum has an incorrect value. It should be FastFunds ("fast_funds"), but instead it is FastFounds ("fast_founds").

@nicklmiller nicklmiller changed the title Fixed PayoutTransactionsType FastFounds to FastFunds Fixed PayoutsTransactionsType FastFounds to FastFunds Sep 30, 2024
@nicklmiller
Copy link
Contributor Author

@armando-rodriguez-cko
Hi Armando, could you please review this pull request? There's a typo in the PayoutsTransactionsType enum that prevents the Metadata RequestCardMetadata API method from parsing the JSON response properly.

@armando-rodriguez-cko armando-rodriguez-cko added bug Something isn't working good first issue Good for newcomers labels Sep 30, 2024
@armando-rodriguez-cko
Copy link
Contributor

Thank you @nicklmiller

armando-rodriguez-cko
armando-rodriguez-cko approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@armando-rodriguez-cko armando-rodriguez-cko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@armando-rodriguez-cko armando-rodriguez-cko merged commit 5d78747 into checkout:master Sep 30, 2024
1 of 4 checks passed
@nicklmiller
Copy link
Contributor Author

You rock! Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armando-rodriguez-cko armando-rodriguez-cko armando-rodriguez-cko approved these changes

Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicklmiller @armando-rodriguez-cko