Fix bug where AlternativePaymentSourceResponse.getType() always retur…

…ned null Releasing as 2.3.1
checkout · Apr 22, 2020 · f68ef70 · f68ef70
1 parent c9c0414
commit f68ef70
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/gradle.properties b/gradle.properties
@@ -1,5 +1,5 @@
 group=com.checkout
-version=2.3.0-SNAPSHOT
+version=2.3.1-SNAPSHOT
 
 maven2_url=https://oss.sonatype.org/service/local/staging/deploy/maven2/
 snapshot_url=https://oss.sonatype.org/content/repositories/snapshots/

diff --git a/src/main/java/com/checkout/payments/AlternativePaymentSourceResponse.java b/src/main/java/com/checkout/payments/AlternativePaymentSourceResponse.java
@@ -8,14 +8,14 @@
 @EqualsAndHashCode(callSuper = true)
 @ToString(callSuper = true)
 public class AlternativePaymentSourceResponse extends HashMap<String, Object> implements ResponseSource {
-    private String type;
+    private static final String TYPE_FIELD = "type";
 
     @Override
     public String getType() {
-        return type;
+        return get(TYPE_FIELD).toString();
     }
 
     public void setType(String type) {
-        this.type = type;
+        put(TYPE_FIELD, type);
     }
 }
diff --git a/src/test/java/com/checkout/payments/AlternativePaymentSourcePaymentsTests.java b/src/test/java/com/checkout/payments/AlternativePaymentSourcePaymentsTests.java
@@ -37,6 +37,7 @@ public void can_get_alternative_payment() throws Exception {
 
         GetPaymentResponse verifiedPayment = getApi().paymentsClient().getAsync(payment.getId()).get();
 
+        Assert.assertEquals("giropay", verifiedPayment.getSource().getType());
         Assert.assertNotNull(verifiedPayment);
         Assert.assertEquals(payment.getId(), verifiedPayment.getId());
         Assert.assertNotNull(verifiedPayment);