-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft for TCP check docs page #1140
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cc @sujaya-sys
|
6fe3842
to
40a3e20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good placeholder for further content, having the UI / CLI / TF / Pulumi in tabs feels a bit much. The reference documentation can be used here to explain the what and why of a TCP check. We can describe shortly how the MaC variants can be used to create one, but we should add the extensive reference docs for a TCPCheck construct for CLI/TF/Pulumi in the relevant sections.
This means I would ditch the tabbed menus once we have these providers and just give a short example inline. This makes it easier to read as scrolling is much more a native reading experience than clicking tabs.
I would just make a small H2 or H3. This will also make them show up in the Table of Contents on the right side. Then we can link to the "extensive" reference docs in the relevant section, e.g. CLI / Constructs.
But lets fix that once we have actual MaC providers.
That makes a lot of sense, thanks Tim! Let's keep the tabs to make it clear for early users that we're only supporting the UI ATM and replace them with proper references once CLI/TF etc. docs are available 👍 |
Overview
Open Questions
weight
in_index
does not seem to work here.