Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft for TCP check docs page #1140

Merged
merged 27 commits into from
Dec 20, 2024
Merged

First draft for TCP check docs page #1140

merged 27 commits into from
Dec 20, 2024

Conversation

sujaya-sys
Copy link
Contributor

@sujaya-sys sujaya-sys commented Nov 25, 2024

Overview

  • Developer documentation for TCP checks
  • For TCP related updates of our existing documentation a separate PR will be created

Open Questions

  • The "TCP check" menu item is shown at the very bottom. I'd like to move it below "API checks". Does anyone know how this can be done? The weight in _index does not seem to work here.

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 1 resolved Dec 20, 2024 0:51am

@pmallol
Copy link
Contributor

pmallol commented Dec 11, 2024

Open Questions

  • The "TCP check" menu item is shown at the very bottom. I'd like to move it below "API checks". Does anyone know how this can be done? The weight in _index does not seem to work here.
  • I commented out the tabs for CLI; TF; Pulumi in the code but they still show up in the preview. Any idea how to avoid that?

cc @sujaya-sys

  1. If I understand correctly we need to explicitly add it to the configuration file:

    [[menu.resources]]
    name = "API checks"
    url = "/docs/api-checks/"
    weight = 20
    [[menu.resources]]
    name = "Browser checks"
    url = "/docs/browser-checks/"
    weight = 30
    [[menu.resources]]
    name = "Heartbeat checks"
    url = "/docs/heartbeat-checks/"
    weight = 35
    [[menu.resources]]
    name = "Multistep checks"
    url = "/docs/multistep-checks/"
    weight = 40

  2. In Hugo templating you can comment out code using {{ % comment %}} [...] {{ % /comment %}} or just deleting the content if not being used for the moment

site/content/docs/monitoring/check-pricing.md Outdated Show resolved Hide resolved
site/content/docs/monitoring/check-results.md Outdated Show resolved Hide resolved
site/content/docs/monitoring/check-results.md Outdated Show resolved Hide resolved
site/content/docs/tcp-checks/_index.md Outdated Show resolved Hide resolved
Copy link
Member

@tnolet tnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good placeholder for further content, having the UI / CLI / TF / Pulumi in tabs feels a bit much. The reference documentation can be used here to explain the what and why of a TCP check. We can describe shortly how the MaC variants can be used to create one, but we should add the extensive reference docs for a TCPCheck construct for CLI/TF/Pulumi in the relevant sections.

This means I would ditch the tabbed menus once we have these providers and just give a short example inline. This makes it easier to read as scrolling is much more a native reading experience than clicking tabs.

I would just make a small H2 or H3. This will also make them show up in the Table of Contents on the right side. Then we can link to the "extensive" reference docs in the relevant section, e.g. CLI / Constructs.

But lets fix that once we have actual MaC providers.

@sujaya-sys
Copy link
Contributor Author

Looks like a good placeholder for further content, having the UI / CLI / TF / Pulumi in tabs feels a bit much. The reference documentation can be used here to explain the what and why of a TCP check. We can describe shortly how the MaC variants can be used to create one, but we should add the extensive reference docs for a TCPCheck construct for CLI/TF/Pulumi in the relevant sections.

This means I would ditch the tabbed menus once we have these providers and just give a short example inline. This makes it easier to read as scrolling is much more a native reading experience than clicking tabs.

I would just make a small H2 or H3. This will also make them show up in the Table of Contents on the right side. Then we can link to the "extensive" reference docs in the relevant section, e.g. CLI / Constructs.

But lets fix that once we have actual MaC providers.

That makes a lot of sense, thanks Tim! Let's keep the tabs to make it clear for early users that we're only supporting the UI ATM and replace them with proper references once CLI/TF etc. docs are available 👍

@sujaya-sys sujaya-sys merged commit 1e1c3ff into main Dec 20, 2024
6 checks passed
@sujaya-sys sujaya-sys deleted the tcp-check-docs branch December 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants