Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add icons / indentation combo [sc-00] #1122

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

tnolet
Copy link
Member

@tnolet tnolet commented Nov 6, 2024

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Notes for the Reviewer

We came to this iteration of the /learn nav menu.

  • (re)adds icons
  • shift submenu chevrons to right to indicate menu structure

Screenshots

CleanShot 2024-11-06 at 15 11 56

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 5:59pm

@Dgiordano33
Copy link
Collaborator

Looks good to me!

@Dgiordano33 Dgiordano33 merged commit e4a3442 into main Nov 7, 2024
4 of 5 checks passed
@Dgiordano33 Dgiordano33 deleted the tnolet/learn-nav-menu-update-sc00 branch November 7, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants