-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply changes / fixes from docs to learn [sc-00] #1120
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renders well, works with new Otel content, maintains URL structure, looks g2g
Feels like we moved backwards in styling? How come we added these dropdown carets instead of the icons? |
@Dgiordano33 I disagree. The icons added nothing but visual noise. Also they had no relation to the topic. The page is much more inline with "best in class" docs I see from other SaaS vendors. This is cleaner and optimizes for a good reading experience. We could add icons if they have a clear purpose and match the topic. |
This isn't a docs section. This is the learn section and supposed to be different. I will add them back, thanks! |
Affected Components
Pre-Requisites
npm run lint
)Notes for the Reviewer