Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply changes / fixes from docs to learn [sc-00] #1120

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

tnolet
Copy link
Member

@tnolet tnolet commented Nov 5, 2024

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Notes for the Reviewer

  • ports over best nav fixes and best practices from docs section.
  • cleans up the list page

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 9:54am

serverless-mom
serverless-mom previously approved these changes Nov 6, 2024
Copy link
Contributor

@serverless-mom serverless-mom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renders well, works with new Otel content, maintains URL structure, looks g2g

@Dgiordano33
Copy link
Collaborator

Feels like we moved backwards in styling? How come we added these dropdown carets instead of the icons?

@tnolet tnolet merged commit eec30a3 into main Nov 6, 2024
2 of 3 checks passed
@tnolet tnolet deleted the tnolet/learn-nav-brushup-sc00 branch November 6, 2024 09:51
@tnolet
Copy link
Member Author

tnolet commented Nov 6, 2024

Feels like we moved backwards in styling? How come we added these dropdown carets instead of the icons?

@Dgiordano33 I disagree. The icons added nothing but visual noise. Also they had no relation to the topic. The page is much more inline with "best in class" docs I see from other SaaS vendors. This is cleaner and optimizes for a good reading experience.

We could add icons if they have a clear purpose and match the topic.

@Dgiordano33
Copy link
Collaborator

This isn't a docs section. This is the learn section and supposed to be different.

I will add them back, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants