credhub: set using contents of file, export to file in json format #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilyGraceSeville7cf
approved these changes
Dec 20, 2022
Comment on lines
+5
to
+6
| # To set a CredHub credential, of type 'value', using the contents of a file: | ||
| credhub set -n <credential-path> -t value -v "$(cat <file-path>)" |
There was a problem hiding this comment.
Suggested change
| # To set a CredHub credential, of type 'value', using the contents of a file: | |
| credhub set -n <credential-path> -t value -v "$(cat <file-path>)" | |
| # To set a CredHub credential, of type `value`, using the contents of a specific file: | |
| credhub set -name <credential-path> -type <password|user|certificate|ssh|rsa> -value "$(cat <in-file>)" |
Optional fix: specific may sound better.
Optional fix: long options can be used for readability.
Optional fix: -type values can be inlined.
Optional fix: path placeholders can be standardized according to this PR.
Comment on lines
+8
to
+9
| # To export descendant CredHub credentials to a file in JSON format: | ||
| credhub export -p <credential-path> -f <file-name>.json -j |
There was a problem hiding this comment.
Suggested change
| # To export descendant CredHub credentials to a file in JSON format: | |
| credhub export -p <credential-path> -f <file-name>.json -j | |
| # To export descendant CredHub credentials to a file in JSON format: | |
| credhub export -private <credential-path> -fail <out-file.json> -output-json |
The same issue as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useful credhub commands