Alignment with upstream #483
Merged
+23,741
−12,628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immediately rerender
… have user only access rights (#236251)
fix #236094
* debt: remove migrations * remove migration test
Fixes #236148
Remove workaround for swiftshader upstream issue
* [prompt snippets]: working on recursive file references * [prompt snippets]: working on file contents codec * [prompt snippets]: implement the `LinesCodecDecoder` * [prompt snippets]: working on the `SimpleTokensCodecDecoder` * [prompt snippets]: implement first version of `PromptSyntaxCodec` * [prompt snippets]: add `Range` attributes to all the tokens * [prompt snippets]: refactoring components to standalone files * [prompt snippets]: move out components to separate files, working on the first unit test * [prompt snippets]: add the first unit test for `LinesDecoder` * [prompt snippets]: add first unit test for the `SimpleDecoder` * [prompt snippets]: refactor `SimpleDecoder` logic * [prompt snippets]: make `SimpleDecoder` handle `\t` characters and improve unit tests * [prompt snippets]: add unit tests for the `ChatbotPromptCodec` codec * [prompt snippets]: add unit test for the `ChatbotPromptReference` * [prompt snippets]: working on enhancing prompt context * [prompt snippets]: enahnce working set file references on submit * [prompt snippets]: cleanup * [prompt snippets]: implement automatic references resolution on file variable addition * [prompt snippets]: implement prompt snippets for implicit context files * [prompt snippets]: improve implicit context file rendering * [prompt snippets]: remove redundant `ChatReference` class * [prompt snippets]: `PromptReference` can now subscribe to filesystem changes, added unit test for the `assertDefined` util * [prompt snippets]: make `LinesDecoder` to also emit `NewLine` tokens, add more unit tests for it * [prompt snippets]: resolve nested references for dynamic variables and update variable label * [prompt snippets]: add nested file references to implicit context of prompt request * [prompt snippets]: variable hover label now includes nested file references * [prompt snippets]: add the `TestDecoder` and `TestLinesDecoder` reusable test utilities * [prompt snippets]: add unit tests for `ChatbotPromptDecoder` decoder * [prompt snippets]: refactor decoders to eliminate static type hacks * [prompt snippets]: improve `BaseDecoder` logic and docs * [prompt snippets]: add unit tests for the new reduce-less logic of the stream * [prompt snippets]: improve doc comments, finish the basic unit test for the `PromptFileReference` class * [prompt snippets]: finish the main unit test for the `PromptFileReference` class * [prompt snippets]: make the `PromptFileReference` class ininite-reference-recursion-proof and add approptiate tests * [prompt snippets]: cleanup * [prompt snippets]: ensure codecs work well with UTF16 codepoints * [prompt snippets]: add `randomInt()` utility and related tests * [prompt snippets]: refactor and add more unit tests * [prompt snippets]: fix unresolved `Buffer` import reference * [prompt snippets]: refactor `LinesDecoder` to use `VSBuffer` as underlying data source * [prompt snippets]: make the `ImplicitContext` to create prompt file reference object only if `prompt-snippets` config value is set * [prompt snippets]: make the `ChatDynamicVariable` to resolve prompt file reference object only if `prompt-snippets` config value is set * [prompt snippets]: localize (+N more) labels * [prompt snippets]: pre PR cleanups * [prompt snippets]: minor cleanups * [prompt snippets]: address some PR feedback, fix an unit test issue * [prompt snippets]: move file to common layers * [prompt snippets]: move base codec types to base/common * [prompt snippets]: move more codec files around * [prompt snippets]: update a code comment * [prompt snippets]: fix `assert.throws()` API incompatibility issue * [prompt snippets]: minor cleanup * [prompt snippets]: improve unit tests for the `PromptFileReference` * [prompt snippets]: skip unit tests of `PromptFileReference` on Windows for now * [prompt snippets]: address PR feedback * [prompt snippets]: add `PromptFileReference.isPromptSnippetFile` getter * [prompt snippets]: move the `assertDefined` utility to `types.ts` * use service injection in `PromptFileReference` class * [prompt snippets]: remove formatting changes * [prompt snippets]: remove more formatting changes * [prompt snippets]: revert more formatting changes * [prompt snippets]: add logic to dispose existing variables in `ChatDynamicVariableModel` * [prompt snippets]: cleanup * [prompt snippets]: minor cleanup * [prompt snippets]: remove redundant disposable registrations, cleanup more formatting changes * [prompt snippets]: improve cross-platform newline handling, add `vertical tab` and `form feed` tokens * [prompt snippets]: minor types naming cleanup * [prompt snippets]: make `ChatPromptCodec` to be a global singleton object and improve doc comments * [prompt snippets]: address PR feedback * [prompt snippets]: remove (+N more) label, ensure that `ChatFileReferences` are scoped to files only * [prompt snippets]: revert changes for the `ImplicitContext` * [prompt snippets]: cleanup changes in `ChatDynamicVariableModel` * [prompt snippets]: revert changes in the `ChatRequestParser` * [prompt snippets]: improve history navigation * [prompt snippets]: address PR feedback * [prompt snippets]: allow non-prompt-snippet files to be referenced, but don't parse their contents
…cript does not have enums
These don't add much
Inline simple methods
Fixes #236122 For css `\0000xx` escaping, if I'm understanding the spec correctly it turns out they eat the space character following them: https://www.w3.org/TR/CSS2/syndata.html#characters My previous fix didn't account for this. Instead I think a safer fix is to switch to use `Css.escape`. This often over-escapes the string by converting characters that don't need it but should be safe and it fixes the original issue
* chore: update [email protected] * chore: bump distro
…ileNotFound` if the file does not exist (#236863)
And only use Loopback flow when not running in Remote Extension Host.
When we cancel, then the promise should be cancelled. If we don't do this, we hang on the first interaction request until we timeout. Fixes the 2nd point in microsoft/vscode#236825 (comment)
fix #236770
* Initial implementation * Refactor editor decoration type
Refactor git blame code
vscode-upstream-sha1: 2bdb3e9 rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Roman Nikitenko <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
|
VS Code tests are failing in the PR checks, investigating it... |
|
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-483-amd64 |
RomanNikitenko
force-pushed
the
alignment-with-upstream
branch
from
82b513a to
c97bc9d
Compare
|
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-483-amd64 |
RomanNikitenko
force-pushed
the
alignment-with-upstream
branch
from
99507b3 to
5572e5d
Compare
|
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-483-amd64 |
Signed-off-by: Roman Nikitenko <[email protected]>
RomanNikitenko
force-pushed
the
alignment-with-upstream
branch
from
5572e5d to
f14588e
Compare
|
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-483-amd64 |
RomanNikitenko
requested review from
azatsarynnyy and
vitaliy-guliy
as code owners
vitaliy-guliy
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
20.18.1version is not available in the images that we use to prepareche-codeassemblyWhat issues does this PR fix?
eclipse-che/che#23291
How to test this PR?
You can use the following links to start a workspace for testing:
ubi8-basedtools container: https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#/https://github.com/RomanNikitenko/web-nodejs-sample/tree/ubi8-basedubi8-nodejs-basedtools container: https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#/https://github.com/RomanNikitenko/web-nodejs-sample/tree/ubi8-nodejs-basedubi9-basedtools container: https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#/https://github.com/RomanNikitenko/web-nodejs-sample/tree/ubi9-basedubi9-nodejs-basedtools container: https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#/https://github.com/RomanNikitenko/web-nodejs-sample/tree/ubi9-nodejs-basedDoes this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folder