Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 linux build #70

Merged
merged 4 commits into from
Aug 6, 2023
Merged

Add arm64 linux build #70

merged 4 commits into from
Aug 6, 2023

Conversation

nmreadelf
Copy link
Collaborator

@nmreadelf nmreadelf commented Jul 26, 2023

Add arm64 build

@auxten auxten marked this pull request as draft July 26, 2023 03:36
@auxten auxten changed the title WIP: Added arm64 build Add arm64 build Jul 26, 2023
@auxten auxten changed the title Add arm64 build Add arm64 linux build Jul 26, 2023
@nmreadelf nmreadelf force-pushed the feat/add-arm-wheel-build branch 17 times, most recently from c0d327f to 9ddff11 Compare July 27, 2023 12:42
@nmreadelf nmreadelf force-pushed the feat/add-arm-wheel-build branch 5 times, most recently from a3c2056 to f4ae32e Compare July 28, 2023 03:41
@nmreadelf nmreadelf force-pushed the feat/add-arm-wheel-build branch 5 times, most recently from b0f990c to 440c303 Compare August 4, 2023 01:28
@nmreadelf nmreadelf marked this pull request as ready for review August 4, 2023 02:03
@nmreadelf nmreadelf force-pushed the feat/add-arm-wheel-build branch 2 times, most recently from f4e26d3 to 7b955f1 Compare August 4, 2023 02:40
@lmangani
Copy link
Contributor

lmangani commented Aug 4, 2023

great work @nmreadelf 🎉
We just need to fix the filename build_arm_whells.yml to build_arm_wheels.yml

@lmangani
Copy link
Contributor

lmangani commented Aug 5, 2023

Last request I promise! The build script is currently located inpackages/build_linux_arm64.sh but the ideal location for this file should be to remain alongside the other chdb scripts in the chdb folder. What do you think @auxten ?

@auxten
Copy link
Member

auxten commented Aug 5, 2023

Last request I promise! The build script is currently located inpackages/build_linux_arm64.sh but the ideal location for this file should be to remain alongside the other chdb scripts in the chdb folder. What do you think @auxten ?

I think we can move it to the chdb directory. I previously placed build_mac_arm64.sh in the packages folder, but it doesn't seem like a good idea. We can move them all to the chdb directory. Don't forget to update the script paths in the Makefile as well. @nmreadelf

@nmreadelf nmreadelf force-pushed the feat/add-arm-wheel-build branch 5 times, most recently from 25d4b6c to 4f34c55 Compare August 5, 2023 14:27
Cleanup Job for Self-Hosted runners to reclaim disk space after successful or failed builds.
@auxten auxten merged commit fdb10d0 into main Aug 6, 2023
2 checks passed
@nmreadelf nmreadelf deleted the feat/add-arm-wheel-build branch August 6, 2023 13:59
auxten pushed a commit that referenced this pull request Aug 15, 2023
* Add arm build

* Update build_arm_whells.yml

* fix build wheel

* Cleanup Job

Cleanup Job for Self-Hosted runners to reclaim disk space after successful or failed builds.

---------

Co-authored-by: Lorenzo Mangani <[email protected]>
auxten pushed a commit that referenced this pull request Nov 9, 2023
* Add arm build

* Update build_arm_whells.yml

* fix build wheel

* Cleanup Job

Cleanup Job for Self-Hosted runners to reclaim disk space after successful or failed builds.

---------

Co-authored-by: Lorenzo Mangani <[email protected]>
auxten pushed a commit that referenced this pull request Dec 8, 2023
* Add arm build

* Update build_arm_whells.yml

* fix build wheel

* Cleanup Job

Cleanup Job for Self-Hosted runners to reclaim disk space after successful or failed builds.

---------

Co-authored-by: Lorenzo Mangani <[email protected]>
auxten pushed a commit that referenced this pull request Jun 7, 2024
* Add arm build

* Update build_arm_whells.yml

* fix build wheel

* Cleanup Job

Cleanup Job for Self-Hosted runners to reclaim disk space after successful or failed builds.

---------

Co-authored-by: Lorenzo Mangani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants