Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating requirements for new catalogues #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

antonioiuliano2
Copy link

Dear eada developers,

I am using eada to perform catalogue conesearch, usually with the VOU-Blazars software.
As I have reported in #8 , some new catalogues are not compatible with the pyvo version which eada is currently built with.

I have found that this can be solved by setting in the setup the version pyvo==1.5, and since it requires at least astropy>4, it is also required to change the astropy version.

Other changes, related to the new pyvo, astropy and python versions:

  • scsTab.votable.to_table() has been replaced with scsTab.votable.get_first_table().to_table(), since now astropy.votable presents a nested structure (https://docs.astropy.org/en/stable/io/votable/index.html);
  • func__doc has been replaced with doc;
  • split has been replaced with str.split;
  • string equality condition "is" has been replaced with "==", according to Python warning;
  • ConfigParser is called with interpolation=None to avoid crashes when reading urls with %2F symbols

Please let me know if these changes are reasonable, and if you have any question.

Best Regards,
Antonio Iuliano

Copy link

docu-mentor bot commented Feb 15, 2024

👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app
powered by Anyscale Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed
in this PR. If you only want me to look at specific files or folders,
you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/"
folder and the file "README.md". All good? Let's get started!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant