Ensure that the environ variable of database location is used through out. #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great library!
I know you all haven't worked on this in a little while but I wanted to offer this PR.
In looking at rxnorm_link_run, the db_file location is determined through
os.environ.get('SQLITE_FILE')
However, when actually running linkage though rxnorm values are looked up using the
RxNormLookup
class which hardcodes the database to always be indatabases
directory.See below from rxnorm.py:
To fix this, I reused the same code from rxnorm_link_run which checks the environment variable first and happily falls back on the
databases
location if it is not populated.