refactor(ffi): replace implicit drop in cffi with explicit drop(Arc::from_raw(var))
#7664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
changed the title
drop(Box::from_raw(var))drop(Box::from_raw(var))
Simon-Laux
changed the title
drop(Box::from_raw(var))drop(Box::from_raw(var))
Simon-Laux
changed the title
drop(Box::from_raw(var))drop(Box::from_raw(var))
link2xt
approved these changes
Jan 1, 2026
iequidoo
approved these changes
Jan 1, 2026
Simon-Laux
force-pushed
the
simon/replace-implicit-drop-in-cffi-with-explicit-drop
branch
from
1eb0e2e to
d64d144
Compare
Simon-Laux
changed the title
drop(Box::from_raw(var))drop(Arc::from_raw(var))
iequidoo
reviewed
Jan 5, 2026
link2xt
approved these changes
Jan 5, 2026
iequidoo
approved these changes
Jan 5, 2026
Simon-Laux
deleted the
simon/replace-implicit-drop-in-cffi-with-explicit-drop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for improved clarity and consistency with existing code.