-
-
Notifications
You must be signed in to change notification settings - Fork 117
feat: connectivity view: move quota up and combine with IMAP state. #7653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
nice! for the layout:
|
|
Do we really need these usage progress bars? Usually percentage is important, so maybe just display smth like |
| if folder == &FolderMeaning::Inbox { | ||
| ret += &*domain_escaped; | ||
| } else { | ||
| ret += &*escaper::encode_minimal(&foldername); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe prepend '/' so that it's clear it's a folder and not a domain? Will be shown as "/DeltaChat" then which is less confusing being next to e.g. "merlinux.eu"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be also confusing when you have multiple accounts on the same relay, because it only shows domain.
either way these are edge-cases and I think they should not block this pr, we can do a follow-up pr if changes become necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having multiple accounts on the same relay isn't a common case i think, but having DeltaChat folder is still the case for non-chatmail.
Multiple accounts on the same relay are useful though if your free space is low. You can periodically switch the primary transport to get more free space.
like described in #7630 (comment)
classical account (with legacy option mvbox)
multi transport