-
-
Notifications
You must be signed in to change notification settings - Fork 110
feat: send pre-message on messages with large attachments #7410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Simon-Laux
wants to merge
14
commits into
pre-messages
Choose a base branch
from
simon/sending-pre-message
base: pre-messages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+409
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
commented
Nov 6, 2025
a283803 to
fcdd28c
Compare
2 tasks
e564a9b to
05a1967
Compare
90b61a1 to
1f0cc45
Compare
Base automatically changed from
simon/remove-partial-download-of-messages
to
pre-messages
November 14, 2025 22:52
e97a448 to
2b900c3
Compare
and modify it to employ message reordering instead of a partially downloaded instance
full-messages and fix exclusion of gossip header, which was broken
`receive_imf::receive_imf_tests::test_dont_reverify_by_self_on_outgoing_msg`
2b900c3 to
305498d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #7367
progress / what's to do:
OutDeliveredis set when a message is sent out and has no remaining send jobs in the smtp table for this message id - so already works since full message and pre message have same msgId in that table.OutMdnRcvdis a "virtual" state ([Tracking Issue] Pre-Messages #7367 (comment)), so going back toOutDeliveredcan't happen anymoreChatFullMessageIdwith<and>like the other message idsreceive_imf::receive_imf_tests::test_dont_reverify_by_self_on_outgoing_msg