Decide on chat assignment before contact lookup #6868
Merged
+779
−594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/chat-assignment
branch
4 times, most recently
from
7cbb203 to
9ac2347
Compare
link2xt
force-pushed
the
link2xt/pgp-contacts
branch
from
1cc8e8b to
dff076c
Compare
link2xt
force-pushed
the
link2xt/chat-assignment
branch
from
79e966d to
bd38fab
Compare
link2xt
force-pushed
the
link2xt/pgp-contacts
branch
from
dff076c to
72614b0
Compare
link2xt
force-pushed
the
link2xt/chat-assignment
branch
from
a7c39b6 to
0cc6f31
Compare
link2xt
force-pushed
the
link2xt/chat-assignment
branch
from
81e829f to
740d1e5
Compare
link2xt
force-pushed
the
link2xt/chat-assignment
branch
from
740d1e5 to
b3ead8c
Compare
Co-authored-by: Hocuri <[email protected]>
Co-authored-by: Hocuri <[email protected]>
Co-authored-by: Hocuri <[email protected]>
Hocuri
reviewed
May 29, 2025
link2xt
force-pushed
the
link2xt/chat-assignment
branch
from
94e566d to
eef4c63
Compare
Co-authored-by: Hocuri <[email protected]>
Co-authored-by: Hocuri <[email protected]>
Hocuri
approved these changes
May 30, 2025
Co-authored-by: Hocuri <[email protected]>
Co-authored-by: Hocuri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to avoid the case where address-contacts are looked up, but the message is assigned to PGP-chat. In case of a group this resulted in adding address-contacts to a PGP-chat at least once during the testing.
It fixes the failing test on the PGP branch and stops ignoring Chat-Group-ID (#6857).