feat: Allow sending unencrypted for chatmail if SignUnencrypted is set #6809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a chatmail user somehow can send unencrypted, setting `SignUnencrypted` is a simplest workaround, it has no meaning for chatmail anyway. Setting `IsChatmail` to 0 has more side effects.
This normally does not happen unless some server admin makes an exception for self. This part is changed in pgp-contacts branch anyway, so let's close it. |
It was exactly the case, but i guess adbenitez resolved the issue in some other way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a chatmail user somehow can send unencrypted, setting
SignUnencryptedis a simplest workaround, it has no meaning for chatmail anyway. SettingIsChatmailto 0 has more side effects.Just a suggestion, feel free to close if it doesn't look useful.