Skip to content

api!: Remove unused config smtp_certificate_checks, deprecate old transport configs #6803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Apr 14, 2025

In preparation for mt, this deprecates the old configs Config::Addr, Config::MailPw, etc. which were used to pass login data to core
and the Config::Configured* configs which I replaced by the transports table.

smtp_certificate_checks was not used by anything, so I removed it instead of deprecating.

Also, fix small bug that the configured server didn't turn up in get_info().

There are still some transport-related configs left, and we will need to discuss what to do about them:

  • SentboxWatch, MvboxMove, OnlyFetchMvbox - maybe they can just stay a global setting
  • ConfiguredInboxFolder, ConfiguredMvboxFolder, ConfiguredSentboxFolder, ConfiguredTrashFolder - we probably need put these into the transports table
  • ConfiguredProvider
  • IsChatmail
  • AuthservIdCandidates - this one we can just remove

Also, fix small bug that the configured server didn't turn
up in get_info().
@Hocuri Hocuri requested a review from link2xt April 14, 2025 10:30
@Hocuri Hocuri changed the title chore: Mark transport old configs as deprecated chore: Mark old transport configs as deprecated Apr 14, 2025
@Hocuri Hocuri changed the title chore: Mark old transport configs as deprecated api!: Remove unused smtp_certificate_checks, deprecate old transport configs Apr 14, 2025
@Hocuri Hocuri changed the title api!: Remove unused smtp_certificate_checks, deprecate old transport configs api!: Remove unused config smtp_certificate_checks, deprecate old transport configs Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant