Fix browser detection logic in navigator.ts #1318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error:
Description:
This PR fixes an issue in the getBrowser function of navigator.ts where the condition 'Edge' || 'Chrome' was always evaluating to 'Edge', causing incorrect browser detection. The updated logic ensures accurate identification of browsers, including Edge and Chrome, by explicitly checking for each browser string separately.
Changes Made:
Updated the getBrowser function:
Replaced the incorrect condition 'Edge' || 'Chrome' with distinct checks for 'Edge' and 'Chrome'.
Combined the redundant checks for 'MSIE' and 'Trident' into a single condition for detecting Internet Explorer ('IE').
Code Refactoring:
Improved the logical order of browser checks for better maintainability.
Ensured that 'Edge' is checked before 'Chrome' to avoid misidentification.
Added comments for clarity in the browser detection logic.