Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Mac CI #3808

Merged
merged 2 commits into from
May 1, 2024
Merged

fix Mac CI #3808

merged 2 commits into from
May 1, 2024

Conversation

matthiasdiener
Copy link
Contributor

@matthiasdiener matthiasdiener commented May 1, 2024

macos-latest is now referring to Mac M1, not x86_64, so we need to use an older version to build for x86_64.

@matthiasdiener matthiasdiener self-assigned this May 1, 2024
@matthiasdiener matthiasdiener marked this pull request as ready for review May 1, 2024 20:01
Copy link
Contributor

@ericjbohm ericjbohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritvikrao
Copy link
Contributor

it says it's still waiting for the spack_macos-latest check. maybe that needs to be commented out?

@matthiasdiener
Copy link
Contributor Author

it says it's still waiting for the spack_macos-latest check. maybe that needs to be commented out?

Should be fixed now (the test was renamed to spack_macos-12)

@matthiasdiener matthiasdiener enabled auto-merge May 1, 2024 21:27
Copy link
Contributor

@ritvikrao ritvikrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good

@matthiasdiener matthiasdiener added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@ritvikrao
Copy link
Contributor

looks like the parameter server test needs to be shortened

@ritvikrao ritvikrao requested a review from adityapb May 1, 2024 21:40
@matthiasdiener matthiasdiener merged commit 192db62 into main May 1, 2024
23 checks passed
@matthiasdiener matthiasdiener deleted the fix-mac-ci branch May 1, 2024 21:41
@matthiasdiener
Copy link
Contributor Author

looks like the parameter server test needs to be shortened

Sure, can you do this in a separate PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants