-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Mac CI #3808
fix Mac CI #3808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
it says it's still waiting for the spack_macos-latest check. maybe that needs to be commented out? |
Should be fixed now (the test was renamed to spack_macos-12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good
looks like the parameter server test needs to be shortened |
Sure, can you do this in a separate PR? |
macos-latest
is now referring to Mac M1, not x86_64, so we need to use an older version to build for x86_64.