This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
Drop support for Ubuntu Focal #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NucciTheBoss
suggested changes
Dec 15, 2023
There was a problem hiding this comment.
Hey @jaimesouza - looks good! The issue with the integration tests is that we need to bump the version of pytest-operator that we are using for the charm integration tests. I have attached a patch file that you can apply to your branch to bump the integration test dependency version.
Let me know if you need any help applying the patch! You need to use gunzip on the patch file because GitHub is still not accepting .patch file uploads... 😞
This was referenced Dec 15, 2023
Updating integration test dependency resolves error with pytest async plugin. Signed-off-by: Jason C. Nucciarone <[email protected]>
NucciTheBoss
suggested changes
Jan 3, 2024
Co-authored-by: Jason Nucciarone <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove support for Ubuntu 20.04 (focal).
How was the code tested?
The code was tested locally on LXD cloud.
Checklist