Skip to content

Updated slider library #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naeemqaswar wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Updated slider library #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f28c5df
Updated slider library
naeemqaswar Jan 26, 2023
ecd4e25
Removed unused code
naeemqaswar Jan 26, 2023
87fec20
Added slider to types dir
naeemqaswar Jan 26, 2023
74a466c
Update Slider.tsx
naeemqaswar Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions example/react-native-media-controls/@types/@react-native-community/slider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
declare module "@react-native-community/slider";
28 changes: 17 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
}
},
"devDependencies": {
"@react-native-community/slider": "^4.4.1",
"@types/react": "^16.9.34",
"@types/react-native": "^0.62.5",
"husky": "^4.2.5",
Expand Down
1 change: 1 addition & 0 deletions src/@types/@react-native-community/slider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
declare module "@react-native-community/slider";
10 changes: 1 addition & 9 deletions src/Slider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from "react";
import { TouchableOpacity, View, Text, Image, ViewStyle } from "react-native";
import RNSlider from "react-native-slider";
import RNSlider from "@react-native-community/slider";
import styles from "./MediaControls.style";
import { humanizeVideoDuration } from "./utils";
import { Props as MediaControlsProps } from "./MediaControls";
Expand Down Expand Up @@ -39,8 +39,6 @@ const Slider = (props: Props) => {
} = props;

const containerStyle = customSliderStyle?.containerStyle || {};
const customTrackStyle = customSliderStyle?.trackStyle || {};
const customThumbStyle = customSliderStyle?.thumbStyle || {};

const dragging = (value: number) => {
const { onSeeking, playerState } = props;
Expand Down Expand Up @@ -77,12 +75,6 @@ const Slider = (props: Props) => {
onSlidingComplete={seekVideo}
maximumValue={Math.floor(duration)}
value={Math.floor(progress)}
trackStyle={[styles.track, customTrackStyle]}
thumbStyle={[
styles.thumb,
customThumbStyle,
{ borderColor: mainColor },
]}
minimumTrackTintColor={mainColor}
/>
</View>
Expand Down