Implement nand #952
Merged
Implement nand #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
char0n
reviewed
Jun 9, 2019
char0n
reviewed
Jun 9, 2019
char0n
reviewed
Jun 9, 2019
char0n
reviewed
Jun 9, 2019
char0n
reviewed
Jun 9, 2019
char0n
reviewed
Jun 9, 2019
dawehner
force-pushed
the
issue-237
branch
2 times, most recently
from
cb90bd4 to
9ab183c
Compare
|
I hopefully addressed all your feedback now! Thank you for the super quick response |
char0n
reviewed
Jun 10, 2019
src/index.d.ts
Outdated
| @@ -979,6 +979,11 @@ declare namespace RamdaAdjunct { | |||
| */ | |||
| neither(firstPredicate: Function, secondPredicate: Function): Function; | |||
|
|
|||
| /** | |||
| * Returns `true` if both arguments are falsy, otherwise `false`. | |||
There was a problem hiding this comment.
This description is not sync with description in nand.js
char0n
reviewed
Jun 10, 2019
test/nand.js
Outdated
| }); | ||
|
|
||
| it('should support currying', function() { | ||
| const trueNand = nand(true); |
There was a problem hiding this comment.
Pls import RA in following way import * as RA from '../src';
can we simplify into ?
it('should support currying', function() {
eq(RA.nand(true, true), false);
eq(RA.nand(true)(true), false);
});
char0n
reviewed
Jun 10, 2019
|
No worries, I totally hear you about opensource projects. Keeping things consistent can be really hard. |
|
I've pushed up a change which hopefully addresses all your feedback. I hope rebasing the PRs is okay. |
char0n
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to solve #237
Note: While committing it, eslint-plugin-ramda had a bug, see ramda/eslint-plugin-ramda#26, so I disabled this specific eslint rule in the configuration. Maybe I'm missing something.