Fix dyno resolving type fields in method signatures
#25944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
riftEmber
changed the title
type fields in method signatures
riftEmber
changed the title
type fields in method signaturestype fields in method signatures
riftEmber
force-pushed
the
use-type-in-sig
branch
from
7c31d5c
to
4897b75
Compare
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
use-type-in-sig
branch
from
f877b86
to
da307cc
Compare
10 tasks
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
use-type-in-sig
branch
2 times, most recently
from
1eac82d
to
caa671a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug preventing dyno from resolving unqualified uses of
typefields or parenless procs in method signatures.Resolved by setting
Resolver::inCompositeTypein more cases where it appears to have been accidentally omitted, and by delaying resolution of parenless procs on generic receivers until later when they are instantiated.Also adds dyno tests for the fixed cases.
Resolves https://github.com/Cray/chapel-private/issues/6689.
Depends on #25932 which should be merged first.
[reviewer info placeholder]
Testing: