tidy up experimental RDMA feature #131
Merged
+68
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: diod_rdma.c does not compile When internal include paths changed recently, diod_rdma.c was not updated. Update include paths.
Problem: when --enable-rdmatrans is explicitly requested, failure to configure it is non-fatal. Make it fatal if the feature cannot be enabled. Also rename "rdmatrans" to "rdma" and label it experimental in the configure help output since it is not production ready. For example, if configured, it unconditionally tries to listen on a hard wired address.
Problem: some packages that are no longer required are installed in CI. Drop libpopt and tcp wrappers.
Problem: the RDMA code is not built in CI so it is subject to rot. Add a build-only check.
Problem: when built with --enable-rdma, diod fails to initialize
with the following error:
# diod -E
diod: waiting on rdma connection
diod: rdma_get_cm_event: Unknown error -1
and dmesg contains
[3890201.976178] ucma_write: process 2106336 (diod) changed security contexts
after opening file descriptor, this is not allowed
Initializng rdma later, after user transitions, seems to avoid this
particular problem at initialization.
Fixes chaos#107
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: RDMA doesn't compile or even begin to run.
Fix some obvious problems with RDMA, short of actually testing it end to end.
The feature is opt-in in configure and is not completely implemented (no config file support for example) so tag it in the configure help as "experimental".
At least the next person that wants to work on it won't have a completely broken starting point.