Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Silo example #1359

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Update: Silo example #1359

merged 2 commits into from
Nov 14, 2024

Conversation

blaisb
Copy link
Contributor

@blaisb blaisb commented Nov 13, 2024

Description

The silo examples works just fine. I just fixed some information within the example to make it slightly easier to read and fixed some typos there and there.

###Comment

Reading this example made me realize that the way we manage floating walls is kinda lame, so I have opened an issue #1360 regarding this.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Copyright headers are present and up to date
  • Lethe documentation is up to date
  • The branch is rebased onto master
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent
  • If parameters are modified, the tests and the documentation of examples are up to date
  • Changelog (CHANGELOG.md) is up to date if the refactor affects the user experience or the codebase

Pull request related list:

  • No other PR is open related to this refactoring
  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If any future works is planned, an issue is opened
  • The PR description is cleaned and ready for merge

@blaisb blaisb added Quick fix Ready for review Next release PR that would need to be merged before the next release labels Nov 13, 2024
Copy link
Collaborator

@lpsaavedra lpsaavedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some minor things to improve

doc/source/examples/dem/silo/silo.rst Outdated Show resolved Hide resolved
doc/source/examples/dem/silo/silo.rst Outdated Show resolved Hide resolved
doc/source/examples/dem/silo/silo.rst Outdated Show resolved Hide resolved
doc/source/examples/dem/silo/silo.rst Outdated Show resolved Hide resolved
Co-authored-by: Laura Prieto Saavedra <[email protected]>
@blaisb blaisb requested a review from lpsaavedra November 14, 2024 18:15
@blaisb blaisb merged commit 2dfc42c into master Nov 14, 2024
@blaisb blaisb deleted the silo-example branch November 14, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next release PR that would need to be merged before the next release Quick fix Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants