-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NS-VOF stong residual formulation #1180
base: master
Are you sure you want to change the base?
Conversation
ca84a0b
to
f2c8ea2
Compare
The debug test still seems to crash? |
It's a bit weird, the |
You need to make sure the restart files does NOT refine the triangulation. Generally this is the case for all the solvers (we do not do mesh refinement when we are reading a restart file), however we don't have any restart tests for VOF I guess,so maybe this issue was there all along. You can check a restart with any VOF cse in the debug to see if that's the issue. Assertions are not run in DEBUG mode, so that it works in release does not mean anything. |
Running on 1 MPI rank(s)... | ||
Number of active cells: 16 | ||
Number of degrees of freedom: 75 | ||
Volume of triangulation: 0.36 | ||
Number of thermal degrees of freedom: 25 | ||
Number of VOF degrees of freedom: 25 | ||
Initial refinement in box - Step 1 of 3 | ||
Number of active cells: 40 | ||
Number of degrees of freedom: 165 | ||
Volume of triangulation: 0.36 | ||
Number of thermal degrees of freedom: 55 | ||
Number of VOF degrees of freedom: 55 | ||
Initial refinement in box - Step 2 of 3 | ||
Number of active cells: 88 | ||
Number of degrees of freedom: 339 | ||
Volume of triangulation: 0.36 | ||
Number of thermal degrees of freedom: 113 | ||
Number of VOF degrees of freedom: 113 | ||
Initial refinement in box - Step 3 of 3 | ||
Number of active cells: 268 | ||
Number of degrees of freedom: 942 | ||
Volume of triangulation: 0.36 | ||
Number of thermal degrees of freedom: 314 | ||
Number of VOF degrees of freedom: 314 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part should not be happening in a restart file. Maybe this option just has neverbeen tested with a restart. IF we are restarting, we should not do any mesh adaptation :)
I will fix the restart with the box refinement feature on another branch, and I will come back to this PR so that it stays a coherent PR. |
@hepap can you rebase? Then this will be ready to go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Hepap! Everything looks good to me! Thanks for the fix! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor things after rebase and this is ready to merge :)
56bbb85
to
f30ab60
Compare
Description
Solution
Testing
Documentation
No modification in the documentation.
Miscellaneous (will be removed when merged)
I guess the tests will fail because of the CI issue. I have still opened the PR since the formulation won't change and I will update the restart of the new test when I have updated my P4est version :)
Checklist (will be removed when merged)
Code related list:
Pull request related list: