Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omit orphan cells from query result (SCE-38) #7409

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Jan 13, 2025

Reason for Change

Changes

  • Remove cell types from query results, where not present in ordering list

Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (71dc1d7) to head (a2eaec8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7409   +/-   ##
=======================================
  Coverage   92.90%   92.91%           
=======================================
  Files         194      194           
  Lines       16831    16845   +14     
=======================================
+ Hits        15637    15651   +14     
  Misses       1194     1194           
Flag Coverage Δ
unittests 92.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaloster kaloster closed this Jan 13, 2025
@kaloster kaloster reopened this Jan 14, 2025
@kaloster kaloster force-pushed the kaloster/ge-filter-fix branch from 40a60d4 to 2e36116 Compare January 14, 2025 21:05
@kaloster kaloster changed the title Test fix: omit orphan cells from query result (SCE-38) Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant