Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codecoverage #7341

Merged
merged 3 commits into from
Sep 19, 2024
Merged

fix: codecoverage #7341

merged 3 commits into from
Sep 19, 2024

Conversation

nayib-jose-gloria
Copy link
Contributor

@nayib-jose-gloria nayib-jose-gloria commented Sep 18, 2024

Reason for Change

Changes

  • upload-artifact v3 now needs an arg to explicitly allow for uploading hidden files (i.e. ".coverage-")

Testing steps

  • run code coverage GHAs in this pr

Copy link
Contributor

Deployment Summary

@nayib-jose-gloria nayib-jose-gloria changed the title chore: bump upload-artifact@v3 to v4 fix: codecoverage Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.93%. Comparing base (0442ec7) to head (199f49f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7341   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files         194      194           
  Lines       16818    16818           
=======================================
  Hits        15629    15629           
  Misses       1189     1189           
Flag Coverage Δ
unittests 92.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Bento007 Bento007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they clearly aren't following conventional commit. This might be broken in other repos we manage.

@nayib-jose-gloria nayib-jose-gloria merged commit 465f4ab into main Sep 19, 2024
42 checks passed
@nayib-jose-gloria nayib-jose-gloria deleted the nayib/fix-coverage branch September 19, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants