Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] [feature] aws-iam-instance-profile reuse existing role and remove SSM support #183

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

mbarrien
Copy link
Contributor

@mbarrien mbarrien commented Mar 24, 2020

Summary

  • Allows passing an existing role to aws-iam-instance-profile, and the module will attach whatever permissions are needed. This allows using roles that are created and managed by other modules (e.g. EKS worker role), but provides ability to attach a standard set of permissions to that role. It will still always create the instance profile, even if the profile will be unused.
  • Removes unused permissions from the aws-iam-instance-profile module for using SSM.

Test Plan

Already in use in CZI internal playground deployment.

@mbarrien mbarrien requested a review from a team as a code owner March 24, 2020 08:30
@mbarrien mbarrien requested a review from ryanking March 24, 2020 17:29
@mbarrien mbarrien merged commit b31cd72 into master Mar 24, 2020
@mbarrien mbarrien deleted the mbarrien/instance-profile-existing-role branch March 24, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants