Initial updates for supporting s3 bucket logging targets. (#302)

* Support s3 bucket logging targets.
chanzuckerberg · Apr 15, 2021 · c0c5731 · c0c5731
1 parent 83e12bc
commit c0c5731
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/aws-s3-private-bucket/main.tf b/aws-s3-private-bucket/main.tf
@@ -110,11 +110,13 @@ resource "aws_s3_bucket" "bucket" {
     }
   }
 
-  # TODO
-  #   logging {
-  #   target_bucket = ""
-  #   target_prefix = ""
-  # }
+  dynamic "logging" {
+    for_each = var.logging_bucket == null ? [] : [var.logging_bucket]
+    content {
+      target_bucket = var.logging_bucket.name
+      target_prefix = var.logging_bucket.prefix
+    }
+  }
 
   server_side_encryption_configuration {
     rule {

diff --git a/aws-s3-private-bucket/variables.tf b/aws-s3-private-bucket/variables.tf
@@ -71,6 +71,12 @@ variable "transfer_acceleration" {
   default = false
 }
 
+variable "logging_bucket" {
+  type        = object({ name = string, prefix = string })
+  description = "Log bucket name and prefix to enable logs for this bucket"
+  default     = null
+}
+
 variable "public_access_block" {
   type    = bool
   default = true