feat: add fileSize to asset downloads #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaloster
force-pushed
the
kaloster/add-file-size
branch
from
115b311 to
93a46d8
Compare
kaloster
force-pushed
the
kaloster/add-file-size
branch
from
847f15e to
661a1f7
Compare
kaloster
force-pushed
the
kaloster/add-file-size
branch
from
661a1f7 to
e651023
Compare
kaloster
commented
Feb 4, 2025
| aggregate: [ | ||
| { | ||
| sum: { | ||
| fileSize: v1.annotation_files_aggregate_for_total.aggregate?.count, |
There was a problem hiding this comment.
this is here to satiate type-check, but doesn't really exist in V1 - let me know if there's a better way of doing it!
There was a problem hiding this comment.
Could also just delete the field, like above where I delete a bunch of fields that aren't in V1!
bchu1
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #1555
Added
fileSizeto:zarr,mrcand All AnnotationsCleanup from previous file size function