-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Complete deposition page migration to V2 #1566
Open
bchu1
wants to merge
7
commits into
main
Choose a base branch
from
bchu/deposition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchu1
force-pushed
the
bchu/deposition
branch
from
January 31, 2025 17:53
01a2eac
to
4e4fd9e
Compare
Frontend Preview URLhttps://bchu-deposition.cryoet.dev.si.czi.technology Updated: 01/31/25 @ 04:18:11 PM PST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1230
methodLinks
is much more complicated than in V1, which useddistinct
to queryannotations
and then assumed that allmethodLinks
were the same for the sameannotationMethod
(turned out to not actually be the case, but whatever). V2 doesn't havedistinct
, onlygroupBy
, which will return a separate object for each array element ofmethodLinks
, so we have to compress them in the FE.