-
Couldn't load subscription status.
- Fork 59
chore: upgrade to bloodhound 0.26.0.0 #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: upgrade to bloodhound 0.26.0.0 #1178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blackheaven thanks a lot, we meant to do this upgrade for a while!
| Aeson.FromJSON a => | ||
| BH.IndexName -> | ||
| body -> | ||
| m [Json.Value] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, aeson is too slow for certain query, so we do need to keep json-syntax here. See: the test/JsonDecode.{hs,py} benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted!
38fa901 to
e33b731
Compare
|
Not sure why it cannot parse |
|
For some reasons, If anyone can have a look at it... |
|
Much better! |
|
@TristanCacqueray nearly done, it fails with: |
|
@TristanCacqueray done! |
|
Greeeen! |
|
That's really good, thanks you @blackheaven ! We'll take it from here shortly! |
I did not run the tests or the project.