Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ActionButton.js): improving filter to catch childrens of ActionButton #1

Merged

Conversation

shobhitsinghal624
Copy link
Member

Original source: mastermoo#373

Improving filter because if children is rendering with a condition ex.:

{callcenter_phone ? (
        <ActionButton.Item
          onPress={handleOpenCall}
          buttonColor={childrenColor || theme.colors.primary}
        >
          <Icon name="phone" type="FontAwesome" />
        </ActionButton.Item>
) : null}

It pass in filter because typeof null is 'object'

This PR closes mastermoo#366

@shobhitsinghal624 shobhitsinghal624 merged commit fbc684b into chakrahq:master Sep 21, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'props' of null
2 participants