add tests

chakra-ui · Nov 28, 2024 · 4c058af · 4c058af
1 parent 67dbf22
commit 4c058af
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 37 deletions.
diff --git a/packages/svelte/src/lib/components/factory/examples/basic.svelte b/packages/svelte/src/lib/components/factory/examples/basic.svelte
@@ -1,5 +1,11 @@
 <script lang="ts">
-  import Ark from '../factory.svelte'
+import Ark from '../factory.svelte'
+
+interface Props {
+  onClickParent?: () => void
+  onClickChild?: () => void
+}
+const { onClickParent, onClickChild }: Props = $props()
 </script>
 
 <Ark
@@ -9,12 +15,13 @@
   data-testid="parent"
   data-part="parent"
   class="parent"
-  style="background: red;"
+  style="background: red"
+  onclick={onClickParent}
 >
   {#snippet render(props)}
     <Ark
       as="span"
-      {...props({ id: 'child', class: 'child', style: 'color: blue' })}
+      {...props({ id: 'child', class: 'child', style: 'color: blue', onclick: onClickChild })}
       data-testid="child"
       data-part="child"
     >

diff --git a/packages/svelte/src/lib/components/factory/factory.test.ts b/packages/svelte/src/lib/components/factory/factory.test.ts
@@ -1,5 +1,6 @@
 import { render, screen } from '@testing-library/svelte'
-import { describe, expect, it } from 'vitest'
+import user from '@testing-library/user-event'
+import { describe, expect, it, vi } from 'vitest'
 import ComponentUnderTest from './examples/basic.svelte'
 
 describe('Ark Factory', () => {
@@ -27,38 +28,13 @@ describe('Ark Factory', () => {
     expect(screen.getByText('Ark UI')).toBeVisible()
   })
 
-  // it('should merge events', async () => {
-  //   const onClickParent = vi.fn()
-  //   const onClickChild = vi.fn()
-  //   render(
-  //     <ark.div data-testid="parent" onClick={onClickParent} asChild>
-  //       <ark.span data-testid="child" onClick={onClickChild} />
-  //     </ark.div>,
-  //   )
-  //   await user.click(screen.getByTestId('child'))
-  //   expect(onClickParent).toHaveBeenCalled()
-  //   expect(onClickChild).toHaveBeenCalled()
-  // })
+  it('should merge events', async () => {
+    const onClickParent = vi.fn()
+    const onClickChild = vi.fn()
+    render(ComponentUnderTest, { onClickParent, onClickChild })
+    await user.click(screen.getByTestId('child'))
 
-  // it('should propagate asChild', async () => {
-  //   render(
-  //     <ark.div data-testid="parent" asChild>
-  //       <ark.span asChild>
-  //         <ark.span>Ark UI</ark.span>
-  //       </ark.span>
-  //     </ark.div>,
-  //   )
-  //   expect(screen.getByText('Ark UI')).toHaveAttribute('data-testid', 'parent')
-  // })
-
-  // it('should stop propagate asChild', async () => {
-  //   render(
-  //     <ark.div data-testid="parent" asChild>
-  //       <ark.span asChild={false}>
-  //         <ark.span>Ark UI</ark.span>
-  //       </ark.span>
-  //     </ark.div>,
-  //   )
-  //   expect(screen.getByText('Ark UI')).not.toHaveAttribute('data-testid', 'parent')
-  // })
+    expect(onClickParent).toHaveBeenCalled()
+    expect(onClickChild).toHaveBeenCalled()
+  })
 })