- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.2k
 
refactor: c++ 17 #7038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            ShortDevelopment
  wants to merge
  13
  commits into
  chakra-core:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
ShortDevelopment:feature/cpp-17
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Draft
                    refactor: c++ 17 #7038
Changes from 1 commit
      Commits
    
    
            Show all changes
          
          
            13 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      b00bba6
              
                Set cpp standard to 17
              
              
                ShortDevelopment e77bbfe
              
                Remove deprecated exception spec
              
              
                ShortDevelopment 87323ae
              
                Fix styling
              
              
                ShortDevelopment a1842fe
              
                Upgrade to catch v1.12.2
              
              
                ShortDevelopment 177a3e0
              
                `std::uncaught_exception` deprecated
              
              
                ShortDevelopment cd81a22
              
                Use `icu4c` on MacOS again
              
              
                ShortDevelopment 6bf3471
              
                Add missing `noexcept(false)`
              
              
                ShortDevelopment b8e02b3
              
                Move msbuild `LanguageStandard` to existing structure
              
              
                ShortDevelopment 5699702
              
                Clear ghost-refs from old stack area
              
              
                ShortDevelopment b8bede4
              
                Prevent compiler optimization
              
              
                ShortDevelopment fc85f2d
              
                Added test
              
              
                ShortDevelopment b8f0814
              
                Merge branch 'master' into feature/cpp-17
              
              
                ShortDevelopment cfe6477
              
                Prevent optimizations on x86
              
              
                ShortDevelopment File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              This file was deleted.
      
      Oops, something went wrong.
      
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.