Skip to content

feat(microsandbox driver): DNS rebind off, fixed VM size, disk-backed docker-data #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eetoc merged 1 commit into from
Jun 24, 2026
Merged

feat(microsandbox driver): DNS rebind off, fixed VM size, disk-backed docker-data #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions pkg/driver/microsandbox_runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,10 +603,24 @@ func (r *microsandboxRuntime) createSandbox(ctx context.Context, session *Sessio
if err != nil {
return nil, err
}
mounts := make(map[string]microsandbox.MountConfig, len(manifest.Mounts))
mounts := make(map[string]microsandbox.MountConfig, len(manifest.Mounts)+1)
for _, mount := range manifest.Mounts {
mounts[mount.GuestPath] = microsandbox.Mount.Bind(mount.HostPath, microsandbox.MountOptions{Readonly: mount.ReadOnly})
}
// Give docker its own disk-backed ext4 volume. The guest root is virtiofs,
// on which the kernel rejects overlayfs (docker's default storage driver)
// with "invalid argument"; a disk-backed named volume keeps docker's
// overlay storage off the virtiofs root. One volume per session so
// concurrent VMs never share the same ext4 image.
mounts["/var/lib/docker"] = microsandbox.Mount.NamedWith(
"docker-data-"+session.Summary.ID,
microsandbox.MountOptions{},
microsandbox.NamedVolumeOptions{
Mode: "ensure-exists",
Kind: "disk",
SizeMiB: 8 * 1024,
},
)
hostPort := uint16(proxyState.HostPort)
guestPort := uint16(r.config.JupyterGuestPort)
imageRef := resolveSessionGuestImage(vmState.Image, session.Summary.GuestImage, defaultGuestImageForDriver(r.config, RuntimeDriverMicrosandbox))
Expand All @@ -627,15 +641,25 @@ func (r *microsandboxRuntime) createSandbox(ctx context.Context, session *Sessio
env["RUNTIME_ROOT"] = r.config.GuestRuntimeRoot
env["JUPYTER_TOKEN"] = proxyState.Token
pullPolicy := microsandboxPullPolicyForImageRef(imageRef)
// Disable DNS rebind protection so guests can resolve names that point at
// private/internal IPs (e.g. an internal container registry).
rebindDisabled := false
network := microsandbox.NetworkPolicy.AllowAll()
network.DNS = &microsandbox.DNSConfig{RebindProtection: &rebindDisabled}
sandbox, err := microsandbox.CreateSandbox(ctx, name,
microsandbox.WithImage(imageRef),
microsandbox.WithWorkdir("/"),
microsandbox.WithShell("/bin/bash"),
microsandbox.WithEnv(env),
microsandbox.WithNetwork(microsandbox.NetworkPolicy.AllowAll()),
microsandbox.WithNetwork(network),
microsandbox.WithPullPolicy(pullPolicy),
microsandbox.WithMounts(mounts),
microsandbox.WithPorts(map[uint16]uint16{hostPort: guestPort}),
// Fixed microVM size: the SDK defaults (512MiB / 1 CPU) are too small
// for docker-in-VM workloads (pulling large images, building from a
// container).
microsandbox.WithMemory(8192),
microsandbox.WithCPUs(4),
)
return sandbox, err
}
Expand Down
Loading