feat: add feature to detect runtime generated classes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running our tool on sorald-0.8.5 does not produce exit code |
MartinWitt
reviewed
Aug 25, 2023
| @@ -33,6 +34,9 @@ public byte[] transform( | |||
|
|
|||
| private static byte[] isLoadedClassWhitelisted(String className, byte[] classfileBuffer) { | |||
| Map<String, List<Provenance>> fingerprints = options.getFingerprints(); | |||
| if (RuntimeClass.isProxyClass(classfileBuffer) || RuntimeClass.isSynthetic(classfileBuffer)) { | |||
There was a problem hiding this comment.
I am really unsure about synthetic classes. We should keep an eye on them and include them in the threat model.
There was a problem hiding this comment.
I would agree with you. We could remove this condition also, as I have never encountered a case yet. The test is also very artificial.
|
LGTM 👍 |
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61