feat(gem-check): add --list flag to pass gem names for list check#370
Draft
sanghanan wants to merge 1 commit into
Draft
feat(gem-check): add --list flag to pass gem names for list check#370sanghanan wants to merge 1 commit into
sanghanan wants to merge 1 commit into
Conversation
Member
Author
|
(moving this to draft, skip none shouldnt be an option) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gem-checkderives thegem list -itarget from the apk package name (stripping ruby[0-9.]+-). This assumes a 1:1 mapping between apk name and gem name, which is not true for packages that bundle multiple gems.Example:
ruby3.2-kube-logging-operator-fluentd-outputsis a collection of fluentd output plugin gems. The apk name is not itself a gem, so the list check fails:To fix this, we add a
--listflag to gem-check:--list foo/--list "foo bar"— check named gem(s) instead of the package-derived guess--list none— skip the list check entirelyWe could do something like: