Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dark mode toggle #88

Merged
merged 2 commits into from
Jan 10, 2025
Merged

add dark mode toggle #88

merged 2 commits into from
Jan 10, 2025

Conversation

bitkarrot
Copy link
Contributor

Add Dark Mode toggle using jekyll's just-the-docs sample switcher
Just a simple first pass. See video.
Will be AFK for a while. Back in the new year.

Screen.Recording.2024-12-21.at.5.22.08.PM.mov

@adamjonas adamjonas requested a review from willcl-ark December 30, 2024 10:51
Copy link
Collaborator

@willcl-ark willcl-ark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work great for me, thanks a lot!

Skimmed through most (but not all) pages and couldn't see any majorly obvious colour clashes or anything else broken 👍🏼

Only left one other comment about default scheme.

@@ -29,6 +29,8 @@ github_username: chaincodelabs

# Build settings
theme: just-the-docs
# Color scheme supports "light" (default) and "dark"
color_scheme: dark
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the default colour scheme to dark.

I think, even as a dark-mode maximalist myself, light-by-default makes most sense on the web. @adamjonas what do you think?

remove default statement
@bitkarrot
Copy link
Contributor Author

closing pr.

@bitkarrot bitkarrot closed this Jan 8, 2025
@willcl-ark
Copy link
Collaborator

😢 Sorry this didn't get merged sooner @bitkarrot! The great Holiday catch-up is well underway now though.

I like and appreciate the change, would you mind re-opening so I can merge it? Happy to take default colourscheme bikeshedding outside this PR.

@bitkarrot bitkarrot reopened this Jan 9, 2025
@bitkarrot
Copy link
Contributor Author

Ah i thought maybe you guys ended up not wanting it.

@willcl-ark willcl-ark merged commit c10c10e into chaincodelabs:master Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants