fix: force symlink dereference when using file command #1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghugues
requested review from
brentleyjones,
cgrindel,
jpsim and
luispadron
as code owners
cgrindel
approved these changes
Oct 19, 2025
cgrindel
requested changes
Oct 19, 2025
cgrindel
approved these changes
Oct 19, 2025
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at c253f55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, the
filecommand dereferences symbolic links by default (--dereferenceimplied). On Linux it's the opposite (--no-dereferenceimplied).We want the dereference behavior on both, otherwise
fileoutputssymbolic link to Versions/Current/MyFrameworkBinaryon Linux when checking the file type of an iOS framework (we then fallback to theotoolcommand which fails).