-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: implement
swift_deps
bzlmod extension (#290)
- Disable Bazel 5.4.0 integration tests while adding support for bzlmod. - Remove nogo target. Not used and was not compiling with bzlmod enabled. - Add `MODULE.bazel`. - Add `swift_deps` bzlmod extension to support generating Swift packages from info in `swift_deps_index.json`. - Add `bazel_package_name` attribute to `local_swift_package` and `swift_package`. It provides the unmolested Bazel repo name for the Swift package. In bzlmod mode, the `repository_ctx.name` value is the canonical repo name (i.e., includes the parent repo name). Related to #276.
- Loading branch information
Showing
20 changed files
with
257 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
module( | ||
name = "cgrindel_swift_bazel", | ||
version = "0.0.0", | ||
) | ||
|
||
# MARK: - Runtime Dependencies | ||
|
||
bazel_dep(name = "cgrindel_bazel_starlib", version = "0.14.9") | ||
bazel_dep(name = "bazel_skylib", version = "1.4.1") | ||
bazel_dep( | ||
name = "rules_go", | ||
version = "0.38.1", | ||
repo_name = "io_bazel_rules_go", | ||
) | ||
bazel_dep(name = "rules_cc", version = "0.0.6") | ||
bazel_dep(name = "platforms", version = "0.0.6") | ||
|
||
# With bzlmod enabled, any dependencies for repositories generated by | ||
# swift_bazel _must_ be a runtime dependency of swift_bazel. | ||
bazel_dep( | ||
name = "rules_swift", | ||
version = "1.6.0", | ||
repo_name = "build_bazel_rules_swift", | ||
) | ||
bazel_dep( | ||
name = "rules_apple", | ||
version = "2.1.0", | ||
repo_name = "build_bazel_rules_apple", | ||
) | ||
|
||
# TODO(chuck): FIX ME! Gazelle needs a new release to get the following fix: | ||
# https://github.com/bazelbuild/bazel-gazelle/pull/1413 | ||
bazel_dep( | ||
name = "gazelle", | ||
version = "0.29.0", | ||
repo_name = "bazel_gazelle", | ||
) | ||
|
||
go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk") | ||
use_repo( | ||
go_sdk, | ||
go_sdk = "go_default_sdk", | ||
) | ||
|
||
go_deps = use_extension("@bazel_gazelle//:extensions.bzl", "go_deps") | ||
go_deps.from_file(go_mod = "//:go.mod") | ||
use_repo( | ||
go_deps, | ||
"com_github_bazelbuild_buildtools", | ||
"com_github_creasty_defaults", | ||
"com_github_deckarep_golang_set_v2", | ||
"com_github_stretchr_testify", | ||
"in_gopkg_yaml_v3", | ||
"org_golang_x_exp", | ||
"org_golang_x_tools", | ||
) | ||
|
||
# MARK: - Dev Dependencies | ||
|
||
bazel_dep( | ||
name = "rules_bazel_integration_test", | ||
version = "0.11.1", | ||
dev_dependency = True, | ||
) | ||
bazel_dep( | ||
name = "bazel_skylib_gazelle_plugin", | ||
version = "1.4.1", | ||
dev_dependency = True, | ||
) | ||
|
||
bazel_binaries = use_extension( | ||
"@rules_bazel_integration_test//:extensions.bzl", | ||
"bazel_binaries", | ||
) | ||
bazel_binaries.download(version_file = "//:.bazelversion") | ||
use_repo( | ||
bazel_binaries, | ||
"build_bazel_bazel_.bazelversion", | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# Intentionally blank | ||
# This exists to force Bazel in bzlmod mode to be strict. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,5 +4,4 @@ CURRENT_BAZEL_VERSION = "//:.bazelversion" | |
|
||
SUPPORTED_BAZEL_VERSIONS = [ | ||
CURRENT_BAZEL_VERSION, | ||
"5.4.0", | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
bazel_dep( | ||
name = "cgrindel_swift_bazel", | ||
version = "0.0.0", | ||
) | ||
local_path_override( | ||
module_name = "cgrindel_swift_bazel", | ||
path = "../..", | ||
) | ||
|
||
bazel_dep(name = "cgrindel_bazel_starlib", version = "0.14.9") | ||
bazel_dep(name = "bazel_skylib", version = "1.4.1") | ||
bazel_dep( | ||
name = "rules_swift", | ||
version = "1.6.0", | ||
repo_name = "build_bazel_rules_swift", | ||
) | ||
|
||
bazel_dep( | ||
name = "bazel_skylib_gazelle_plugin", | ||
version = "1.4.1", | ||
dev_dependency = True, | ||
) | ||
bazel_dep( | ||
name = "gazelle", | ||
version = "0.29.0", | ||
dev_dependency = True, | ||
repo_name = "bazel_gazelle", | ||
) | ||
|
||
swift_deps = use_extension( | ||
"@cgrindel_swift_bazel//:extensions.bzl", | ||
"swift_deps", | ||
) | ||
swift_deps.from_file( | ||
deps_index = "//:swift_deps_index.json", | ||
) | ||
use_repo( | ||
swift_deps, | ||
"swiftpkg_my_local_package", | ||
"swiftpkg_swift_argument_parser", | ||
"swiftpkg_swift_log", | ||
"swiftpkg_swiftformat", | ||
) | ||
|
||
# IDEA | ||
# use_repo(swift_deps, "swift_deps") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# Intentionally blank | ||
# This exists to force Bazel in bzlmod mode to be strict. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
"""Bazel module extensions.""" | ||
|
||
load("//swiftpkg/bzlmod:swift_deps.bzl", _swift_deps = "swift_deps") | ||
|
||
swift_deps = _swift_deps |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
module github.com/cgrindel/swift_bazel | ||
|
||
go 1.19 | ||
go 1.18 | ||
|
||
require ( | ||
github.com/bazelbuild/bazel-gazelle v0.29.0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
load("@bazel_skylib//:bzl_library.bzl", "bzl_library") | ||
load("@cgrindel_bazel_starlib//bzlformat:defs.bzl", "bzlformat_pkg") | ||
|
||
bzlformat_pkg(name = "bzlformat") | ||
|
||
bzl_library( | ||
name = "swift_deps", | ||
srcs = ["swift_deps.bzl"], | ||
visibility = ["//visibility:public"], | ||
deps = ["//swiftpkg/internal:deps_indexes"], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
"""Implementation for `swift_deps` bzlmod extension.""" | ||
|
||
load("//swiftpkg/internal:deps_indexes.bzl", "deps_indexes") | ||
load("//swiftpkg/internal:local_swift_package.bzl", "local_swift_package") | ||
load("//swiftpkg/internal:swift_package.bzl", "swift_package") | ||
|
||
# MARK: - swift_deps bzlmod Extension | ||
|
||
def _declare_pkg_from_package(package, deps_index_label): | ||
if package.remote_pkg != None: | ||
swift_package( | ||
name = package.name, | ||
bazel_package_name = package.name, | ||
commit = package.remote_pkg.commit, | ||
remote = package.remote_pkg.remote, | ||
dependencies_index = deps_index_label, | ||
) | ||
elif package.local_pkg != None: | ||
local_swift_package( | ||
name = package.name, | ||
bazel_package_name = package.name, | ||
path = package.local_pkg.path, | ||
dependencies_index = deps_index_label, | ||
) | ||
else: | ||
fail("Found package '{}' without a remote or local.".format( | ||
package.identity, | ||
)) | ||
|
||
def _declare_pkgs_from_file(module_ctx, from_file): | ||
index_json = module_ctx.read(from_file.deps_index) | ||
deps_index = deps_indexes.new_from_json(index_json) | ||
for package in deps_index.packages_by_id.values(): | ||
_declare_pkg_from_package(package, from_file.deps_index) | ||
|
||
def _swift_deps_impl(module_ctx): | ||
for mod in module_ctx.modules: | ||
for from_file in mod.tags.from_file: | ||
_declare_pkgs_from_file(module_ctx, from_file) | ||
|
||
_from_file_tag = tag_class( | ||
attrs = { | ||
"deps_index": attr.label( | ||
mandatory = True, | ||
doc = "A `swift_deps_index.json`.", | ||
), | ||
}, | ||
doc = "Load Swift packages from a file generated by the Gazelle extension.", | ||
) | ||
|
||
swift_deps = module_extension( | ||
implementation = _swift_deps_impl, | ||
tag_classes = { | ||
"from_file": _from_file_tag, | ||
}, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.