Skip to content

refactor: simplify reload chat #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: simplify reload chat #156

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61b852a
refactor: simplify handleModelChange in AssistMessagePart component
notshekhar Jul 13, 2025
21cc417
fix: update tooltip content in AssistMessagePart component to reflect…
notshekhar Jul 13, 2025
f706267
Merge branch 'main' into hotfix/reload
brrock Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 16 additions & 23 deletions src/components/message-parts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
import { useCopy } from "@/hooks/use-copy";

import { AnimatePresence, motion } from "framer-motion";
import { SelectModel } from "./select-model";

Check failure on line 40 in src/components/message-parts.tsx

View workflow job for this annotation

GitHub Actions / lint_and_type_check 

'SelectModel' is declared but its value is never read.
import {
deleteMessageAction,
deleteMessagesByChatIdAfterTimestampAction,
Expand All @@ -48,7 +48,7 @@
import {
ChatMentionSchema,
ChatMessageAnnotation,
ChatModel,

Check failure on line 51 in src/components/message-parts.tsx

View workflow job for this annotation

GitHub Actions / lint_and_type_check 

'ChatModel' is declared but its value is never read.
ClientToolInvocation,
} from "app-types/chat";

Expand Down Expand Up @@ -292,7 +292,7 @@
.unwrap();
}, [message.id]);

const handleModelChange = (model: ChatModel) => {
const handleModelChange = () => {
safe(() => setIsLoading(true))
.ifOk(() =>
threadId
Expand All @@ -308,15 +308,7 @@
return messages;
}),
)
.ifOk(() =>
reload({
body: {
model,
action: "update-assistant",
id: threadId,
},
}),
)
.ifOk(() => reload())
.ifFail((error) => toast.error(error.message))
.watch(() => setIsLoading(false))
.unwrap();
Expand Down Expand Up @@ -355,21 +347,22 @@
<Tooltip>
<TooltipTrigger asChild>
<div>
<SelectModel onSelect={handleModelChange}>
<Button
data-testid="message-edit-button"
variant="ghost"
size="icon"
className={cn(
"size-3! p-4! opacity-0 group-hover/message:opacity-100",
)}
>
{<RefreshCw />}
</Button>
</SelectModel>
{/* <SelectModel onSelect={handleModelChange}> */}
<Button
data-testid="message-edit-button"
variant="ghost"
size="icon"
onClick={handleModelChange}
className={cn(
"size-3! p-4! opacity-0 group-hover/message:opacity-100",
)}
>
{<RefreshCw />}
</Button>
{/* </SelectModel> */}
</div>
</TooltipTrigger>
<TooltipContent>Change Model</TooltipContent>
<TooltipContent>Reload Chat</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
Expand Down
Loading