[fix] - retire LM-Studio-era leftovers: orphaned sandbox mock + config host consistency#652
Draft
cgfixit wants to merge 1 commit into
Draft
[fix] - retire LM-Studio-era leftovers: orphaned sandbox mock + config host consistency#652cgfixit wants to merge 1 commit into
cgfixit wants to merge 1 commit into
Conversation
…nsistency) - Delete .claude/skills/CyClaw-Sandbox/mock_lmstudio.py: orphaned since the sandbox flow moved to mock_ollama.py — repo-wide grep finds no active reference (only self-references and dated audit docs). The active mock (mock_ollama.py) is referenced by the skill, the codex variant, and tests. - config.yaml agentic.deepagent_github.base_url: localhost -> 127.0.0.1, matching every other loopback endpoint's host form in the file (both pass _is_loopback; consistency only). Carries the same DevSkim ignore marker as its sibling loopback URLs so the scanner treatment stays uniform. Verified: config-guard 0 failures/0 warnings; config.yaml parses; the remaining localhost entries are the intentional allowed-origins/hosts lists. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0138hmScu3tFU4v1jzvFUwVT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Two small Ollama-migration leftovers from the Phase 1 scan:
.claude/skills/CyClaw-Sandbox/mock_lmstudio.py(port 1234, simulatesqwen2.5-7b-instruct). Orphaned since the sandbox flow moved tomock_ollama.py: repo-wide grep finds no active reference — only self-references and dated audit docs — while the activemock_ollama.pyis referenced by the sandbox skill, the.codexvariant, andtests/.config.yamlagentic.deepagent_github.base_url:localhost→127.0.0.1— the lonelocalhostlocal-endpoint while every sibling (models.local_llm,fallback,guardrails) uses127.0.0.1. Both pass_is_loopback; consistency only. Carries the sameDevSkim: ignore DS162092,DS137138marker as the sibling loopback URLs so scanner treatment stays uniform.Invariant / Governance Impact: None — a dead file under
.claude/(ruff-excluded, not production code) and a host-string form change inside a disabled-by-default block.config-guard: 0 failures / 0 warnings.Types of changes
Scope note: Out-of-band tooling + config hygiene.
Benefits / why
config.yaml.Risks to monitor
mock_lmstudio.pyby hand, it disappears —git checkout <sha> -- .claude/skills/CyClaw-Sandbox/mock_lmstudio.pyrestores it, andmock_ollama.pyin the same directory covers the same OpenAI-compatible surface on the current port.Further comments
Verified:
config-guard0/0;config.yamlparses; remaininglocalhoststrings are the intentionalallowed_origins/allowed_hostslists (untouched);tests/test_agentic_deepagent_optional.pyunaffected (skips without optional deps, as designed). Companion to #651 (harness fallback parity) — no shared files between the two.🤖 Generated with Claude Code
https://claude.ai/code/session_0138hmScu3tFU4v1jzvFUwVT
Generated by Claude Code