Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dio library doc #2344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dio library doc #2344

wants to merge 1 commit into from

Conversation

mcmah309
Copy link

@mcmah309 mcmah309 commented Dec 22, 2024

Not sure why these exist, they make the generated docs look squirrely https://pub.dev/documentation/dio/latest/dio/

Signed-off-by: Henry <[email protected]>
@mcmah309 mcmah309 requested a review from a team as a code owner December 22, 2024 00:46
@AlexV525
Copy link
Member

Could you elaborate "squirrely"?

@mcmah309
Copy link
Author

"Migration Guide" and "Plugins" point to the same location and are just the regular docs for the dio library. It does not make sense to have these as categories.

The side view currently looks like this -

Libraries
browser
io
  Migration Guide
  dio
  Plugins
  dio

While it should look like

Libraries
browser
dio
io

@AlexV525
Copy link
Member

Maybe the problem is library dio should be library only.

@mcmah309
Copy link
Author

mcmah309 commented Dec 22, 2024

I don't see how that would remove the unnecessary categories.

But we may have to remove

"Migration Guide":

as well. I think the changes in this PR are enough though.

@AlexV525
Copy link
Member

These are necessary topics IMO. Is there a proper way to keep them while removing the extra library entries?

@mcmah309
Copy link
Author

I don't think the changes in this PR will remove the topics. Just the sub-categories under "Libraries". "Topics" should remain the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants