-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content(Complete User Profile): Updated the language, commented out button #598
content(Complete User Profile): Updated the language, commented out button #598
Conversation
…age and gleif link
…ncial-institution-button-language-update
@shindigira Just one thing. Can you re-swap in the following text? Complete your user profile (associated financial institutions)
Complete your user profile (no associated financial institutions)
Once these changes are live on AWS I will re-check and check off the list on the design review issue. |
…f github.com:cfpb/sbl-frontend into 597-add-financial-institution-button-language-update
@natalia-fitzgerald Updated the PR. Will just need an approval and merge-in before putting on AWS |
@shindigira - Looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One minor nit, if you want to change it.
@@ -100,7 +103,9 @@ function FormErrorHeader< | |||
: 'Missing entry' | |||
}${ | |||
// eslint-disable-next-line @typescript-eslint/no-magic-numbers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: I don't think you need this eslint exception now that you changed it to One
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
closes #597
Note
Tasks - Complete your user profile (associated financial institutions)
Tasks - Complete your user profile (no associated financial institutions)
Notable Changes
/landing
otherwise/
How to Test
Screenshot - Normal
Screenshot - With Errors
Screenshot - Error Summary with breadcrumb
Screenshot - Warning Summary with breadcrumb
References
#578